Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

featureflagservice: bump OTP version to 26 #903

Merged
merged 3 commits into from
May 26, 2023

Conversation

tsloughter
Copy link
Member

@tsloughter tsloughter commented May 23, 2023

Changes

Fix for #901

Bumps the Erlang/OTP version to 26.0 in the featureflagservice Dockerfile.

This should only be merged if it can be verified by someone that the issue on ARM that was found in 25 is no longer an issue on 26.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@tsloughter tsloughter requested a review from a team May 23, 2023 20:32
@tsloughter tsloughter force-pushed the otp-26 branch 3 times, most recently from cb6f6c1 to 3d10260 Compare May 23, 2023 20:40
@tsloughter tsloughter marked this pull request as draft May 23, 2023 20:42
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This fixed the build problem in arm, mac M1.

@tsloughter tsloughter marked this pull request as ready for review May 24, 2023 15:56
@puckpuck puckpuck merged commit 435de4d into open-telemetry:main May 26, 2023
AlexanderWert pushed a commit to AlexanderWert/opentelemetry-demo that referenced this pull request Jul 24, 2023
* featureflagservice: bump OTP version to 26

* featureflagservice: bump ecto_sql to build on otp-26

---------

Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* featureflagservice: bump OTP version to 26

* featureflagservice: bump ecto_sql to build on otp-26

---------

Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants