Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): updating valid card validation expected status code #998

Merged
merged 2 commits into from
Jul 22, 2023
Merged

fix(tests): updating valid card validation expected status code #998

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c75ca6
fix(tests): updating valid card validation expected status code
xoscar Jul 21, 2023
ec9dabb
Merge branch 'main' into update-valid-card-assertion
austinlparker Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions test/tracetesting/payment-service/valid-credit-card.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
type: Test
spec:
id: payment-valid-credit-card
name: 'Payment: valid credit card'
name: "Payment: valid credit card"
description: Charge customer with a valid credit card
trigger:
type: grpc
Expand All @@ -27,12 +27,13 @@ spec:
}
}
specs:
- name: It should call Charge method successfully
selector: span[tracetest.span.type="rpc" name="grpc.oteldemo.PaymentService/Charge" rpc.system="grpc" rpc.method="Charge" rpc.service="oteldemo.PaymentService"]
# instead of returning status_code 0, this service returns 1, but it works as intended
assertions:
- attr:rpc.grpc.status_code = 1
- name: It should return a transaction ID
selector: span[tracetest.span.type="general" name="Tracetest trigger"]
assertions:
- attr:tracetest.response.body | json_path '$.transactionId' != ""
- name: It should call Charge method successfully
selector: span[tracetest.span.type="rpc" name="grpc.oteldemo.PaymentService/Charge" rpc.system="grpc" rpc.method="Charge" rpc.service="oteldemo.PaymentService"]
# instead of returning status_code 0, this service can return 1 depending on timing, but it works as intended
assertions:
# updating assertion to match 0 and 1
- attr:rpc.grpc.status_code <= 1
- name: It should return a transaction ID
selector: span[tracetest.span.type="general" name="Tracetest trigger"]
assertions:
- attr:tracetest.response.body | json_path '$.transactionId' != ""