Fix IDE1515

open-telemetry · Oct 30, 2024 · 4d7811f · 4d7811f
1 parent e626ada
commit 4d7811f
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 16 deletions.
diff --git a/.../OpenTelemetry.Instrumentation.Wcf.Tests/Tools/DownstreamInstrumentationBindingElement.cs b/.../OpenTelemetry.Instrumentation.Wcf.Tests/Tools/DownstreamInstrumentationBindingElement.cs
@@ -6,7 +6,7 @@
 
 namespace OpenTelemetry.Instrumentation.Wcf.Tests.Tools;
 
-public class DownstreamInstrumentationBindingElement : BindingElement
+internal class DownstreamInstrumentationBindingElement : BindingElement
 {
     public override BindingElement Clone()
     {

diff --git a/test/OpenTelemetry.Instrumentation.Wcf.Tests/Tools/DownstreamInstrumentationChannel.cs b/test/OpenTelemetry.Instrumentation.Wcf.Tests/Tools/DownstreamInstrumentationChannel.cs
@@ -7,10 +7,10 @@
 
 namespace OpenTelemetry.Instrumentation.Wcf.Tests.Tools;
 
-public class DownstreamInstrumentationChannel : DispatchProxy
+internal class DownstreamInstrumentationChannel : DispatchProxy
 {
     public const string DownstreamInstrumentationSourceName = "DownstreamInstrumentationSource";
-    private static readonly ActivitySource DownstreamInstrumentationSource = new ActivitySource(DownstreamInstrumentationSourceName);
+    private static readonly ActivitySource DownstreamInstrumentationSource = new(DownstreamInstrumentationSourceName);
     private static bool failNextReceive;
 
     private object? Target { get; set; }

diff --git a/.../OpenTelemetry.Instrumentation.Wcf.Tests/Tools/DownstreamInstrumentationChannelFactory.cs b/.../OpenTelemetry.Instrumentation.Wcf.Tests/Tools/DownstreamInstrumentationChannelFactory.cs
@@ -6,19 +6,14 @@
 
 namespace OpenTelemetry.Instrumentation.Wcf.Tests.Tools;
 
-public class DownstreamInstrumentationChannelFactory<TChannel> : DispatchProxy
+internal class DownstreamInstrumentationChannelFactory<TChannel> : DispatchProxy
     where TChannel : notnull
 {
     public IChannelFactory<TChannel>? Target { get; set; }
 
     protected override object? Invoke(MethodInfo? targetMethod, object?[]? args)
     {
         var returnValue = targetMethod!.Invoke(this.Target, args);
-        if (targetMethod.Name == nameof(IChannelFactory<TChannel>.CreateChannel))
-        {
-            return DownstreamInstrumentationChannel.Create((TChannel)returnValue!);
-        }
-
-        return returnValue;
+        return targetMethod.Name == nameof(IChannelFactory<TChannel>.CreateChannel) ? DownstreamInstrumentationChannel.Create((TChannel)returnValue!) : returnValue;
     }
 }
diff --git a/...penTelemetry.Instrumentation.Wcf.Tests/Tools/DownstreamInstrumentationEndpointBehavior.cs b/...penTelemetry.Instrumentation.Wcf.Tests/Tools/DownstreamInstrumentationEndpointBehavior.cs
@@ -7,7 +7,7 @@
 
 namespace OpenTelemetry.Instrumentation.Wcf.Tests.Tools;
 
-public class DownstreamInstrumentationEndpointBehavior : IEndpointBehavior
+internal class DownstreamInstrumentationEndpointBehavior : IEndpointBehavior
 {
     public void AddBindingParameters(ServiceEndpoint endpoint, BindingParameterCollection bindingParameters)
     {

diff --git a/test/OpenTelemetry.Instrumentation.Wcf.Tests/WCF/IServiceContract.cs b/test/OpenTelemetry.Instrumentation.Wcf.Tests/WCF/IServiceContract.cs
@@ -6,7 +6,7 @@
 namespace OpenTelemetry.Instrumentation.Wcf.Tests;
 
 [ServiceContract(Namespace = "http://opentelemetry.io/", Name = "Service", SessionMode = SessionMode.Allowed)]
-public interface IServiceContract
+internal interface IServiceContract
 {
     [OperationContract]
     Task<ServiceResponse> ExecuteAsync(ServiceRequest request);

diff --git a/test/OpenTelemetry.Instrumentation.Wcf.Tests/WCF/Service.netfx.cs b/test/OpenTelemetry.Instrumentation.Wcf.Tests/WCF/Service.netfx.cs
@@ -12,7 +12,7 @@ namespace OpenTelemetry.Instrumentation.Wcf.Tests;
     InstanceContextMode = InstanceContextMode.Single,
     UseSynchronizationContext = false,
     Name = "Service")]
-public class Service : IServiceContract
+internal class Service : IServiceContract
 {
     public Task ErrorAsync()
     {

diff --git a/test/OpenTelemetry.Instrumentation.Wcf.Tests/WCF/ServiceClient.cs b/test/OpenTelemetry.Instrumentation.Wcf.Tests/WCF/ServiceClient.cs
@@ -6,7 +6,7 @@
 
 namespace OpenTelemetry.Instrumentation.Wcf.Tests;
 
-public class ServiceClient : ClientBase<IServiceContract>, IServiceContract
+internal class ServiceClient : ClientBase<IServiceContract>, IServiceContract
 {
     public ServiceClient(Binding binding, EndpointAddress remoteAddress)
         : base(binding, remoteAddress)

diff --git a/test/OpenTelemetry.Instrumentation.Wcf.Tests/WCF/ServiceRequest.cs b/test/OpenTelemetry.Instrumentation.Wcf.Tests/WCF/ServiceRequest.cs
@@ -6,7 +6,7 @@
 namespace OpenTelemetry.Instrumentation.Wcf.Tests;
 
 [DataContract]
-public class ServiceRequest
+internal class ServiceRequest
 {
     public ServiceRequest(string payload)
     {

diff --git a/test/OpenTelemetry.Instrumentation.Wcf.Tests/WCF/ServiceResponse.cs b/test/OpenTelemetry.Instrumentation.Wcf.Tests/WCF/ServiceResponse.cs
@@ -6,7 +6,7 @@
 namespace OpenTelemetry.Instrumentation.Wcf.Tests;
 
 [DataContract]
-public class ServiceResponse
+internal class ServiceResponse
 {
     public ServiceResponse(string payload)
     {