Drop netcoreapp3.1 from CI & update testing framework in Instrumentation.GrpcCore to net6.0 #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It happens due to changes default activity format in net5 https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/5.0/default-activityidformat-changed
It is default in net5.0+
Kielek
added
infra
to mitigate Unable to load shared library 'libdl.so' or one of its dependencies. In order to help diagnose loading problems, consider setting the LD_DEBUG environment variable: liblibdl.so: cannot open shared object file: No such file or directory
|
@pcwiese, @vishweshbankwar please review. @pcwiese, could you please create request based on #1201 ? it will help us maintaining reviewers automatically. |
Here is my request for membership |
pcwiese
approved these changes
Aug 1, 2023
utpilla
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1031
Changes
Grpcpackage in test to latest released. It is currently obsolete, unmaintained package so update to the latest release seems to be reasonableAs part of working on this
redis-test (netcoreapp3.1)was removed from required buildsWhile reviewing consider to review each commit separately. History is more descriptive.
For significant contributions please make sure you have completed the following items:
[ ] AppropriateCHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed