[repo] Use project files for tests in dedicated CI flows #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
+ Coverage 73.91% 74.07% +0.16%
==========================================
Files 267 258 -9
Lines 9615 9551 -64
==========================================
- Hits 7107 7075 -32
+ Misses 2508 2476 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
LGTM
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\test\OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.Tests\bin\Release\net462\OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.Tests.dll
[xUnit.net 00:00:00.02] xUnit.net VSTest Adapter v2.5.0.1+5ebf84cd75 (64-bit .NET Framework 4.8.9186.0)
[xUnit.net 00:00:01.01] Discovering: OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.Tests
[xUnit.net 00:00:01.25] Discovered: OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.Tests
[xUnit.net 00:00:01.26] Starting: OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.Tests
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigWithLocationTagTransformTest.VerifyInstallationWhenGlobalAndNonGlobalLocationTagExists [279 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigWithLocationTagTransformTest.VerifyInstallationToLocationTagWithEmptyPathWithNoModules [3 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigWithLocationTagTransformTest.VerifyInstallationWhenNonGlobalLocationTagExists [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigWithLocationTagTransformTest.VerifyInstallationToLocationTagWithDotPathWithGlobalModules [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigWithLocationTagTransformTest.VerifyInstallationToLocationTagWithDotPathWithNoModules [8 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigWithLocationTagTransformTest.VerifyInstallationToLocationTagWithEmptyPathAndExistingModules [2 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigWithLocationTagTransformTest.VerifyInstallationToLocationTagWithDotPathAndExistingModules [4 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigWithLocationTagTransformTest.VerifyInstallationToLocationTagWithEmptyPathWithGlobalModules [9 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigTransformTest.VerifyUpdateWithIntegratedModeWebConfig [295 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigTransformTest.VerifyUninstallationWithBasicWebConfig [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigTransformTest.VerifyUninstallationWithUserModules [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigTransformTest.VerifyInstallationToWebConfigWithoutModules [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigTransformTest.VerifyInstallationToBasicWebConfig [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigTransformTest.VerifyInstallationToEmptyWebConfig [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigTransformTest.VerifyUpdateWithTypeRenamingWebConfig [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigTransformTest.VerifyInstallationToWebConfigWithUserModules [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigTransformTest.VerifyUpdateNewerVersionWebConfig [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.WebConfigTransformTest.VerifyUninstallWithIntegratedPrecondition [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Has_Started_Returns_Correctly [239 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Stop_Lost_Activity [128 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Do_Not_Restore_Activity_When_There_Is_No_Activity_In_Context [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Stop_Activity_With_AspNetListener_Enabled [[11](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/6478157578/job/17589520561?pr=1390#step:6:12)1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Create_RootActivity_From_W3C_Traceparent [47 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Create_RootActivity_And_Start_Activity [2 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Should_Not_Create_RootActivity_If_AspNetListener_Not_Enabled [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Stop_Root_While_Child_Is_Current [2 ms]
[xUnit.net 00:00:02.40] OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Restore_Baggage [SKIP]
[xUnit.net 00:00:02.40] Temporarily disable until stable.
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Stop_Root_Activity_With_All_Children [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Stop_Root_Activity_With_[12](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/6478157578/job/17589520561?pr=1390#step:6:13)9_Nesting_Depth [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Restore_Activity [8 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Create_RootActivity_From_W3C_Traceparent_With_Baggage [10 ms]
Skipped OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Restore_Baggage [1 ms]
Error Message:
Temporarily disable until stable.
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Stop_Root_Activity_If_It_Is_Broken [7 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Stop_Activity_Without_AspNetListener_Enabled [1[13](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/6478157578/job/17589520561?pr=1390#step:6:14) ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Create_RootActivity_And_Saved_In_HttContext [2 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Fire_Exception_Events [2 ms]
[xUnit.net 00:00:02.57] Finished: OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule.Tests
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Can_Create_RootActivityWithTraceState_From_W3C_TraceContext [38 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Do_Not_Restore_Activity_When_It_Is_Not_Lost [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.ActivityHelperTest.Should_Not_Create_RootActivity_If_AspNetActivity_Not_Enabled [1 ms]
Test Run Successful.
Total tests: 38
Passed: 37
Skipped: 1
Total time: 7.0490 Seconds
Test run for D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\test\OpenTelemetry.Instrumentation.AspNet.Tests\bin\Release\net462\OpenTelemetry.Instrumentation.AspNet.Tests.dll (.NETFramework,Version=v4.6.2)
Microsoft (R) Test Execution Command Line Tool Version [17](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/6478157578/job/17589520561?pr=1390#step:6:18).7.1 (x64)
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\test\OpenTelemetry.Instrumentation.AspNet.Tests\bin\Release\net462\OpenTelemetry.Instrumentation.AspNet.Tests.dll
[xUnit.net 00:00:00.01] xUnit.net VSTest Adapter v2.5.0.1+5ebf84cd75 (64-bit .NET Framework 4.8.9[18](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/6478157578/job/17589520561?pr=1390#step:6:19)6.0)
[xUnit.net 00:00:00.59] Discovering: OpenTelemetry.Instrumentation.AspNet.Tests
[xUnit.net 00:00:00.85] Discovered: OpenTelemetry.Instrumentation.AspNet.Tests
[xUnit.net 00:00:00.86] Starting: OpenTelemetry.Instrumentation.AspNet.Tests
Passed OpenTelemetry.Instrumentation.AspNet.Tests.EventSourceTest.EventSourceTest_AspNetInstrumentationEventSource [45 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInMetricsListenerTests.HttpDurationMetricIsEmitted [1 s]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "https://localhost/", url: "***localhost/", routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False, filter: null, recordException: False) [405 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "https://localhost/", url: "https://localhost/", routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False, filter: null, recordException: False) [2 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "http://localhost/", url: "http://localhost/", routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: True, filter: null, recordException: False) [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "http://localhost/api/value", url: "http://localhost/api/value", routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False, filter: "{ThrowException}", recordException: False) [5 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "http://localhost/", url: "http://localhost/", routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False, filter: null, recordException: False) [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "https://localhost:1843/subroute/10", url: "https://localhost:1843/subroute/10", routeType: 4, routeTemplate: "subroute/{customerId}", setStatusToErrorInEnrich: False, filter: null, recordException: False) [13 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "http://localhost:443/", url: "http://localhost:443/", routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False, filter: null, recordException: False) [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "http://localhost/api/value", url: "http://localhost/api/value", routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False, filter: "/api/value", recordException: False) [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "http://localhost/", url: "http://localhost/", routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False, filter: null, recordException: True) [12 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "https://localhost:443/about_attr_route/10", url: "https://localhost:443/about_attr_route/10", routeType: 2, routeTemplate: "about_attr_route/{customerId}", setStatusToErrorInEnrich: False, filter: null, recordException: False) [[20](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/6478157578/job/17589520561?pr=1390#step:6:21) ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "https://localhost:80/Home/Index.htm?q1=v1&q2=v2#Fr"···, url: "***localhost:80/Home/Index.htm?"···, routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False, filter: null, recordException: False) [3 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "http://localhost:1880/api/weatherforecast", url: "http://localhost:1880/api/weatherforecast", routeType: 3, routeTemplate: "api/{controller}/{id}", setStatusToErrorInEnrich: False, filter: null, recordException: False) [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "http://localhost:80/Index", url: "http://localhost:80/Index", routeType: 1, routeTemplate: "{controller}/{action}/{id}", setStatusToErrorInEnrich: False, filter: null, recordException: False) [6 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "https://localhost:80/", url: "https://localhost:80/", routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False, filter: null, recordException: False) [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "https://localhost:80/Home/Index.htm?q1=v1&q2=v2#Fr"···, url: "https://localhost:80/Home/Index.htm?q1=v1&q2=v2#Fr"···, routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False, filter: null, recordException: False) [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.ExtractContextIrrespectiveOfSamplingDecision(samplingDecision: Drop) [84 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.ExtractContextIrrespectiveOfSamplingDecision(samplingDecision: RecordAndSample) [2 ms]
[xUnit.net 00:00:02.69] Finished: OpenTelemetry.Instrumentation.AspNet.Tests
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.ExtractContextIrrespectiveOfSamplingDecision(samplingDecision: RecordOnly) [1 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.ExtractContextIrrespectiveOfTheFilterApplied [5 ms]
Passed OpenTelemetry.Instrumentation.AspNet.Tests.BasicTests.AddAspNetInstrumentation_BadArgs [2 ms]
Test Run Successful.
Total tests: [22](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/6478157578/job/17589520561?pr=1390#step:6:23)
Passed: 22
Total time: 6.67[60](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/6478157578/job/17589520561?pr=1390#step:6:61) Seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1386 (comment)
Changes
#1386 combined Instrumentation.AspNet + Instrumentation.AspNet.TelemetryHttpModule into the same CI & release workflows but only the tests for Instrumentation.AspNet were being run. This PR changes the workflows to use the project files which now have targets for testing.