Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] stress nullable #2255

Merged
merged 4 commits into from
Oct 28, 2024
Merged

[Exporter.Geneva] stress nullable #2255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3c2df5
Geneva.Stress - enalbe nullable
Kielek Oct 28, 2024
704bb09
Fix CS8622
Kielek Oct 28, 2024
69dc743
Fix CS8618
Kielek Oct 28, 2024
60143f3
Merge branch 'main' into geneva-stress-nullable
Kielek Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/OpenTelemetry.Exporter.Geneva.Stress/DummyServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public void Start()
this.serverSocket.Bind(this.endpoint);
this.serverSocket.Listen(20);

Console.CancelKeyPress += (object sender, ConsoleCancelEventArgs args) =>
Console.CancelKeyPress += (object? sender, ConsoleCancelEventArgs args) =>
{
Console.WriteLine("Program is terminating.");
this.serverSocket.Close();
Expand Down
1 change: 0 additions & 1 deletion test/OpenTelemetry.Exporter.Geneva.Stress/OpenTelemetry.Exporter.Geneva.Stress.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net48;net472;net471;net47;net462</TargetFrameworks>
<OutputType>Exe</OutputType>
<NoWarn>$(NoWarn);SA1308;SA1201</NoWarn>
<Nullable>disable</Nullable>
</PropertyGroup>

<ItemGroup>
Expand Down
8 changes: 4 additions & 4 deletions test/OpenTelemetry.Exporter.Geneva.Stress/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ private class WindowsOptions
private class LinuxOptions
{
[Option('p', "path", Default = "/var/run/default_fluent.socket", HelpText = "Specify a path for Unix domain socket.")]
public string Path { get; set; }
public string? Path { get; set; }
}

[Verb("server", HelpText = "Start a dummy server on Linux.")]
private class ServerOptions
{
[Option('p', "path", HelpText = "Specify a path for Unix domain socket.", Required = true)]
public string Path { get; set; }
public string? Path { get; set; }
}

[Verb("ExporterCreation", HelpText = "Validate exporter dispose behavior")]
Expand Down Expand Up @@ -78,12 +78,12 @@ private static int RunExporterCreation()

private static int RunLinux(LinuxOptions options)
{
return EntryPoint(() => InitTracesOnLinux(options.Path), RunTraces);
return EntryPoint(() => InitTracesOnLinux(options.Path!), RunTraces);
}

private static int RunServer(ServerOptions options)
{
var server = new DummyServer(options.Path);
var server = new DummyServer(options.Path!);
server.Start();
return 0;
}
Expand Down
Loading