Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/Extensions] Prepare to .NET9 #2265

Merged
merged 14 commits into from
Oct 29, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Oct 29, 2024

Changes

Follow up #2251

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner October 29, 2024 05:35
@github-actions github-actions bot added the comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS label Oct 29, 2024
@github-actions github-actions bot added the comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment label Oct 29, 2024
@github-actions github-actions bot added the comp:extensions Things related to OpenTelemetry.Extensions label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.29%. Comparing base (71655ce) to head (3451d26).
Report is 560 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2265       +/-   ##
===========================================
+ Coverage   73.91%   87.29%   +13.37%     
===========================================
  Files         267       50      -217     
  Lines        9615     1149     -8466     
===========================================
- Hits         7107     1003     -6104     
+ Misses       2508      146     -2362     
Flag Coverage Δ
unittests-Extensions 88.63% <ø> (?)
unittests-Extensions.Enrichment 100.00% <100.00%> (?)
unittests-Instrumentation.AWS 86.06% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...OpenTelemetry.Extensions.AWS/AWSXRayIdGenerator.cs 93.15% <100.00%> (+32.03%) ⬆️
...elemetry.Extensions.AWS/Trace/AWSXRayPropagator.cs 79.83% <100.00%> (+0.32%) ⬆️
...ions.Enrichment/Internal/TraceEnrichmentActions.cs 100.00% <100.00%> (ø)

... and 281 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek merged commit 9b8b4ba into open-telemetry:main Oct 29, 2024
60 checks passed
@Kielek Kielek deleted the net9prep-extensions branch October 29, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment comp:extensions Things related to OpenTelemetry.Extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants