[repo/Runtime] Prepare to .NET9 #2281
Conversation
github-actions
bot
added
the
comp:instrumentation.runtime
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2281 +/- ##
===========================================
+ Coverage 73.91% 98.02% +24.11%
===========================================
Files 267 2 -265
Lines 9615 152 -9463
===========================================
- Hits 7107 149 -6958
+ Misses 2508 3 -2505
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| #pragma warning disable SA1313 | ||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="RuntimeMetrics"/> class. | ||
| /// </summary> | ||
| /// <param name="options">The options to define the metrics.</param> | ||
| public RuntimeMetrics(RuntimeInstrumentationOptions options) | ||
| /// <param name="_1">The options to define the metrics.</param> | ||
| public RuntimeMetrics(RuntimeInstrumentationOptions _1) | ||
| #pragma warning restore SA1313 |
There was a problem hiding this comment.
A bit odd. Why not just remove the parameter?
-public RuntimeMetrics(RuntimeInstrumentationOptions _1)
+public RuntimeMetrics()Could make the whole class static. But need some way to make sure it is bootstrapped.
Like instead of...
var instrumentation = new RuntimeMetrics(options);
builder.AddMeter(RuntimeMetrics.MeterInstance.Name);
return builder.AddInstrumentation(() => instrumentation);Do something like...
GC.KeepAlive(RuntimeMetrics.SomethingAccessibleToTriggetStaticCtor)
return builder.AddMeter(RuntimeMetrics.MeterInstance.Name);There was a problem hiding this comment.
Created #2289
The problem is with public contract if extension method. We need to keep this as the package is released as stable. Then we need to suppress warning there. I am not against, but lets do it seprately
public static MeterProviderBuilder AddRuntimeInstrumentation(
this MeterProviderBuilder builder,
Action<RuntimeInstrumentationOptions>? configure)
| @@ -24,14 +24,16 @@ internal sealed class RuntimeMetrics | |||
| #endif | |||
| private const int NumberOfGenerations = 3; | |||
|
|
|||
| private static readonly string[] GenNames = new string[] { "gen0", "gen1", "gen2", "loh", "poh" }; | |||
| private static readonly string[] GenNames = ["gen0", "gen1", "gen2", "loh", "poh"]; | |||
| #if NET | |||
There was a problem hiding this comment.
Is this #if NET added by some automation tool?
There was a problem hiding this comment.
Nope, it was manual modification. isGcInfoAvailable was marked as unused on some target frameworks. I manually modified it.
Changes
Follow up #2251
Merge requirement checklist
[ ] Unit tests added/updated[ ] AppropriateCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)