Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL security scan #55

Merged

Conversation

amanbrar1999
Copy link
Contributor

Motivation

Follow up to issue open-telemetry/oteps#144

CodeQL is GitHub's static analysis engine which scans repos for security vulnerabilities. As the project grows and we near GA it might be useful to have a workflow which checks for security vulnerabilities with every PR so we can ensure every incremental change is following best development practices. Also passing basic security checks will also make sure that there aren't any glaring issues for our users.

Changes

  • This PR adds CodeQL security checks to the repo
  • After every run the workflow uploads the results to GitHub. Details on the run and security alerts will show up in the security tab of this repo.

Workflow Triggers

  • daily cron job at 12:00am
  • workflow_dispatch (in case maintainers want to trigger a security check manually)

This workflow is identical to the one that already exists in the core dotnet repository

cc- @alolita

@amanbrar1999 amanbrar1999 requested a review from a team December 31, 2020 18:41
@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #55 (a38dd5c) into master (37ed2cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files          28       28           
  Lines         766      766           
=======================================
  Hits          507      507           
  Misses        259      259           

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants