Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GenevaLogExporter Benchmarks #605

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Update GenevaLogExporter Benchmarks #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 84 additions & 22 deletions test/OpenTelemetry.Exporter.Geneva.Benchmark/Exporter/LogExporterBenchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,48 @@
// </copyright>

using System.Collections.Generic;
using System.Diagnostics;
using BenchmarkDotNet.Attributes;
using Microsoft.Extensions.Logging;
using OpenTelemetry.Logs;

/*
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.19044.1766 (21H2)
Intel Core i7-4790 CPU 3.60GHz (Haswell), 1 CPU, 8 logical and 4 physical cores
.NET SDK=6.0.301
[Host] : .NET 6.0.6 (6.0.622.26707), X64 RyuJIT
DefaultJob : .NET 6.0.6 (6.0.622.26707), X64 RyuJIT


| Method | IncludeFormattedMessage | Mean | Error | StdDev | Gen 0 | Allocated |
|-------------------------- |------------------------ |-----------:|---------:|---------:|-------:|----------:|
| LoggerWithMessageTemplate | False | 1,107.3 ns | 19.34 ns | 17.15 ns | 0.0858 | 360 B |
| LoggerWithDirectLoggerAPI | False | 1,027.4 ns | 8.92 ns | 7.91 ns | 0.1183 | 496 B |
| LoggerWithSourceGenerator | False | 1,081.5 ns | 4.53 ns | 4.24 ns | 0.0763 | 320 B |
| SerializeLogRecord | False | 825.1 ns | 6.88 ns | 5.74 ns | 0.0305 | 128 B |
| LoggerWithMessageTemplate | True | 1,123.3 ns | 2.24 ns | 1.87 ns | 0.0858 | 360 B |
| LoggerWithDirectLoggerAPI | True | 1,005.8 ns | 2.26 ns | 2.00 ns | 0.1183 | 496 B |
| LoggerWithSourceGenerator | True | 1,083.9 ns | 8.73 ns | 6.82 ns | 0.0763 | 320 B |
| SerializeLogRecord | True | 827.1 ns | 6.45 ns | 6.03 ns | 0.0305 | 128 B |
BenchmarkDotNet=v0.13.1, OS=Windows 10.0.22000
Intel Core i7-9700 CPU 3.00GHz, 1 CPU, 8 logical and 8 physical cores
.NET SDK=7.0.100-preview.6.22352.1
[Host] : .NET 6.0.8 (6.0.822.36306), X64 RyuJIT
DefaultJob : .NET 6.0.8 (6.0.822.36306), X64 RyuJIT

Without Scopes

| Method | IncludeFormattedMessage | Mean | Error | StdDev | Gen 0 | Allocated |
|-------------------------- |------------------------ |---------:|---------:|---------:|-------:|----------:|
| LoggerWithMessageTemplate | False | 979.5 ns | 11.46 ns | 10.72 ns | 0.0401 | 256 B |
| LoggerWithDirectLoggerAPI | False | 887.9 ns | 17.24 ns | 16.13 ns | 0.0620 | 392 B |
| LoggerWithSourceGenerator | False | 965.8 ns | 16.84 ns | 15.75 ns | 0.0343 | 216 B |
| SerializeLogRecord | False | 696.5 ns | 13.94 ns | 14.92 ns | 0.0038 | 24 B |
| Export | False | 744.9 ns | 12.91 ns | 12.08 ns | 0.0038 | 24 B |
| LoggerWithMessageTemplate | True | 978.6 ns | 18.95 ns | 19.46 ns | 0.0401 | 256 B |
| LoggerWithDirectLoggerAPI | True | 878.3 ns | 11.43 ns | 10.69 ns | 0.0620 | 392 B |
| LoggerWithSourceGenerator | True | 942.8 ns | 14.55 ns | 13.61 ns | 0.0343 | 216 B |
| SerializeLogRecord | True | 707.3 ns | 9.01 ns | 8.42 ns | 0.0038 | 24 B |
| Export | True | 752.0 ns | 8.97 ns | 7.49 ns | 0.0038 | 24 B |


With Scopes (https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/545)

| Method | IncludeFormattedMessage | Mean | Error | StdDev | Median | Gen 0 | Allocated |
|-------------------------- |------------------------ |-----------:|---------:|---------:|-----------:|-------:|----------:|
| LoggerWithMessageTemplate | False | 1,042.8 ns | 19.34 ns | 54.55 ns | 1,022.1 ns | 0.0572 | 360 B |
| LoggerWithDirectLoggerAPI | False | 953.4 ns | 13.90 ns | 13.00 ns | 950.4 ns | 0.0782 | 496 B |
| LoggerWithSourceGenerator | False | 962.1 ns | 18.93 ns | 17.71 ns | 957.6 ns | 0.0496 | 320 B |
| SerializeLogRecord | False | 722.8 ns | 6.26 ns | 5.23 ns | 722.9 ns | 0.0200 | 128 B |
| Export | False | 789.2 ns | 15.11 ns | 14.14 ns | 787.3 ns | 0.0200 | 128 B |
| LoggerWithMessageTemplate | True | 986.8 ns | 12.56 ns | 11.13 ns | 983.4 ns | 0.0572 | 360 B |
| LoggerWithDirectLoggerAPI | True | 932.1 ns | 18.25 ns | 20.29 ns | 924.7 ns | 0.0782 | 496 B |
| LoggerWithSourceGenerator | True | 980.0 ns | 15.56 ns | 14.55 ns | 979.6 ns | 0.0496 | 320 B |
| SerializeLogRecord | True | 737.5 ns | 13.46 ns | 12.59 ns | 738.8 ns | 0.0200 | 128 B |
| Export | True | 772.2 ns | 14.02 ns | 13.11 ns | 774.8 ns | 0.0200 | 128 B |
*/

namespace OpenTelemetry.Exporter.Geneva.Benchmark
Expand All @@ -48,13 +68,14 @@ public class LogExporterBenchmarks
private readonly ILoggerFactory loggerFactory;
private readonly GenevaLogExporter exporter;
private readonly LogRecord logRecord;
private readonly Batch<LogRecord> batch;

[Params(true, false)]
public bool IncludeFormattedMessage { get; set; }

public LogExporterBenchmarks()
{
// for total cost of logging + msgpack serialization
// for total cost of logging + msgpack serialization + export
this.loggerFactory = LoggerFactory.Create(builder => builder
.AddOpenTelemetry(loggerOptions =>
{
Expand All @@ -74,8 +95,9 @@ public LogExporterBenchmarks()

this.logger = this.loggerFactory.CreateLogger("TestLogger");

// For msgpack serialization alone
// For msgpack serialization + export
this.logRecord = GenerateTestLogRecord();
this.batch = GenerateTestLogRecordBatch();
this.exporter = new GenevaLogExporter(new GenevaExporterOptions
{
ConnectionString = "EtwSession=OpenTelemetry",
Expand Down Expand Up @@ -123,18 +145,58 @@ public void SerializeLogRecord()
this.exporter.SerializeLogRecord(this.logRecord);
}

internal static LogRecord GenerateTestLogRecord()
[Benchmark]
public void Export()
{
this.exporter.Export(this.batch);
}

[GlobalCleanup]
public void Cleanup()
{
this.loggerFactory.Dispose();
this.batch.Dispose();
this.exporter.Dispose();
}

private static LogRecord GenerateTestLogRecord()
{
var items = new List<LogRecord>(1);
var factory = LoggerFactory.Create(builder => builder
using var factory = LoggerFactory.Create(builder => builder
.AddOpenTelemetry(loggerOptions =>
{
loggerOptions.AddInMemoryExporter(items);
}));

var logger = factory.CreateLogger("SerializationTest");
var logger = factory.CreateLogger("TestLogger");
logger.LogInformation("Hello from {food} {price}.", "artichoke", 3.99);
return items[0];
}

private static Batch<LogRecord> GenerateTestLogRecordBatch()
{
var items = new List<LogRecord>(1);
using var batchGeneratorExporter = new BatchGeneratorExporter();
using var factory = LoggerFactory.Create(builder => builder
.AddOpenTelemetry(loggerOptions =>
{
loggerOptions.AddProcessor(new SimpleLogRecordExportProcessor(batchGeneratorExporter));
}));

var logger = factory.CreateLogger("TestLogger");
logger.LogInformation("Hello from {food} {price}.", "artichoke", 3.99);
return batchGeneratorExporter.Batch;
}

private class BatchGeneratorExporter : BaseExporter<LogRecord>
{
public Batch<LogRecord> Batch { get; set; }

public override ExportResult Export(in Batch<LogRecord> batch)
{
this.Batch = batch;
return ExportResult.Success;
}
}
}
}