[Instrumentation.AWSLambda] Issue/aws lambda http server semantic conventions attributes

src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+* Implemented minimal HTTP Server semantic conventions attributes set
+  ([#626](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/626))
+
 ## 1.1.0-beta.2
 
 Release PR: [#590](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/590)

src/OpenTelemetry.Instrumentation.AWSLambda/Implementation/AWSLambdaHttpUtils.cs

@@ -43,17 +43,17 @@ internal static IEnumerable<KeyValuePair<string, object>> GetHttpTags<TInput>(TI
             switch (input)
             {
                 case APIGatewayProxyRequest request:
-                    httpScheme = AWSLambdaUtils.GetHeaderValues(request, HeaderXForwardedProto)?.FirstOrDefault();
+                    httpScheme = AWSLambdaUtils.GetHeaderValues(request, HeaderXForwardedProto)?.LastOrDefault();
                     httpTarget = string.Concat(request.RequestContext?.Path ?? string.Empty, GetQueryString(request));
                     httpMethod = request.HttpMethod;
-                    var hostHeader = AWSLambdaUtils.GetHeaderValues(request, HeaderHost)?.FirstOrDefault();
+                    var hostHeader = AWSLambdaUtils.GetHeaderValues(request, HeaderHost)?.LastOrDefault();
                     (hostName, hostPort) = GetHostAndPort(httpScheme, hostHeader);
                     break;
                 case APIGatewayHttpApiV2ProxyRequest requestV2:
-                    httpScheme = AWSLambdaUtils.GetHeaderValues(requestV2, HeaderXForwardedProto)?.FirstOrDefault();
+                    httpScheme = AWSLambdaUtils.GetHeaderValues(requestV2, HeaderXForwardedProto)?.LastOrDefault();
                     httpTarget = string.Concat(requestV2.RawPath ?? string.Empty, GetQueryString(requestV2));
                     httpMethod = requestV2.RequestContext?.Http?.Method;
-                    var hostHeaderV2 = AWSLambdaUtils.GetHeaderValues(requestV2, HeaderHost)?.FirstOrDefault();
+                    var hostHeaderV2 = AWSLambdaUtils.GetHeaderValues(requestV2, HeaderHost)?.LastOrDefault();
                     (hostName, hostPort) = GetHostAndPort(httpScheme, hostHeaderV2);
                     break;
             }

test/OpenTelemetry.Instrumentation.AWSLambda.Tests/Implementation/AWSLambdaHttpUtilsTests.cs

@@ -62,6 +62,31 @@ public void GetHttpTags_APIGatewayProxyRequest_ReturnsCorrectTags()
             AssertTags(expectedTags, actualTags);
         }
 
+        [Fact]
+        public void GetHttpTags_APIGatewayProxyRequestWithMultiValueHeader_UsesLastValue()
+        {
+            var request = new APIGatewayProxyRequest
+            {
+                MultiValueHeaders = new Dictionary<string, IList<string>>
+                {
+                    { "X-Forwarded-Proto", new List<string> { "https", "http" } },
+                    { "Host", new List<string> { "localhost:1234", "myhost:432" } },
+                },
+            };
+
+            var actualTags = AWSLambdaHttpUtils.GetHttpTags(request);
+
+            var expectedTags = new Dictionary<string, object>
+            {
+                { "http.target", string.Empty },
+                { "http.scheme", "http" },
+                { "net.host.name", "myhost" },
+                { "net.host.port", 432 },
+            };
+
+            AssertTags(expectedTags, actualTags);
+        }
+
         [Fact]
         public void GetHttpTags_APIGatewayHttpApiV2ProxyRequest_ReturnsCorrectTags()
         {
@@ -97,6 +122,31 @@ public void GetHttpTags_APIGatewayHttpApiV2ProxyRequest_ReturnsCorrectTags()
             AssertTags(expectedTags, actualTags);
         }
 
+        [Fact]
+        public void GetHttpTags_APIGatewayHttpApiV2ProxyRequestWithMultiValueHeader_UsesLastValue()
+        {
+            var request = new APIGatewayHttpApiV2ProxyRequest
+            {
+                Headers = new Dictionary<string, string>
+                {
+                    { "X-Forwarded-Proto", "https,http" },
+                    { "Host", "localhost:1234,myhost:432" },
+                },
+            };
+
+            var actualTags = AWSLambdaHttpUtils.GetHttpTags(request);
+
+            var expectedTags = new Dictionary<string, object>
+            {
+                { "http.target", string.Empty },
+                { "http.scheme", "http" },
+                { "net.host.name", "myhost" },
+                { "net.host.port", 432 },
+            };
+
+            AssertTags(expectedTags, actualTags);
+        }
+
         [Fact]
         public void SetHttpTagsFromResult_APIGatewayProxyResponse_SetsCorrectTags()
         {