Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.MysqlData] Compatibility with Mysql.Data 8.0.31. #692

Merged
merged 8 commits into from
Oct 14, 2022

Conversation

moonheart
Copy link
Member

Fixes #691.

Changes

Mysql.Data removed the static property
MySql.Data.MySqlClient.MySqlTrace.QueryAnalysisEnabled since 8.0.31, this causes failing to enable mysql query tracing.

Because of this, Users must enable TracingDriver by adding connection option Logging=true manually if they are using Mysql.Data 8.0.31 or later.

I try to set QueryAnalysisEnabled use reflection here to avoid possible exceptions.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #692 (42115e4) into main (a0aa56c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 42115e4 differs from pull request most recent head 316573c. Consider uploading reports for the commit 316573c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   77.69%   77.69%           
=======================================
  Files         175      175           
  Lines        5249     5251    +2     
=======================================
+ Hits         4078     4080    +2     
  Misses       1171     1171           
Impacted Files Coverage Δ
...trumentation.MySqlData/MySqlDataInstrumentation.cs 83.69% <100.00%> (+0.36%) ⬆️

@moonheart moonheart marked this pull request as ready for review October 13, 2022 13:05
@moonheart moonheart requested a review from a team October 13, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrumentation is nor working with MySql.Data 8.0.31
4 participants