Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.Process] Dropping Snapshot #718

Merged
merged 7 commits into from
Oct 21, 2022
Merged

[Instrumentation.Process] Dropping Snapshot #718

merged 7 commits into from
Oct 21, 2022

Conversation

Yun-Ting
Copy link
Contributor

Update to use Process.Refresh() on each callback after benchmarking the perf #717 and found it cheap.
Also, addressing #664 (comment).

@Yun-Ting Yun-Ting mentioned this pull request Oct 19, 2022
Merged
@Yun-Ting Yun-Ting marked this pull request as ready for review October 19, 2022 23:53
@Yun-Ting Yun-Ting requested a review from a team October 19, 2022 23:53
@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Merging #718 (b7bc97d) into main (bb9462c) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head b7bc97d differs from pull request most recent head 1810c15. Consider uploading reports for the commit 1810c15 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   77.74%   77.55%   -0.19%     
==========================================
  Files         176      176              
  Lines        5343     5298      -45     
==========================================
- Hits         4154     4109      -45     
  Misses       1189     1189
Impacted Files Coverage Δ
...elemetry.Instrumentation.Process/ProcessMetrics.cs 100.00% <100.00%> (ø)

noahfalk
noahfalk approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(I still have concerns about the cpu utilization metric and using PrivateMemory for the process.memory.virtual metric, but neither of those concerns needs to hold up this PR)

@Kielek Kielek added the comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process label Oct 21, 2022
CodeBlanch
CodeBlanch approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utpilla utpilla merged commit 63f944c into open-telemetry:main Oct 21, 2022
@Yun-Ting Yun-Ting deleted the yunl/dropSnapshot branch October 22, 2022 00:46
@Yun-Ting Yun-Ting mentioned this pull request Nov 6, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@utpilla utpilla utpilla approved these changes

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@noahfalk noahfalk noahfalk approved these changes

@Kielek Kielek Kielek approved these changes

Assignees

@Yun-Ting Yun-Ting

Labels
comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yun-Ting @Kielek @noahfalk @reyang @CodeBlanch @utpilla