-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.MysqlData] Compatibility with Mysql.Data 8.0.32. #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingBuilder constructor since 8.0.32
Kielek
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for so fast fix
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Kielek
added
the
comp:instrumentation.mysqldata
Things related to OpenTelemetry.Instrumentation.MySqlData
label
Jan 18, 2023
pellared
reviewed
Jan 18, 2023
src/OpenTelemetry.Instrumentation.MySqlData/MySqlDataInstrumentation.cs
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
- Coverage 68.55% 68.48% -0.08%
==========================================
Files 183 183
Lines 6981 7002 +21
==========================================
+ Hits 4786 4795 +9
- Misses 2195 2207 +12
|
pellared
approved these changes
Jan 18, 2023
Kielek
approved these changes
Jan 18, 2023
Merging despite CI failure, due to #903 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mysql.Data add optional param
isAnalyzed
to MySqlConnectionStringBuilder constructor since 8.0.32Fixes #901.
Changes
Added logic to check MySqlConnectionStringBuilder constructor.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes