Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.MysqlData] Compatibility with Mysql.Data 8.0.32. #902

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

moonheart
Copy link
Member

@moonheart moonheart commented Jan 18, 2023

Mysql.Data add optional param isAnalyzed to MySqlConnectionStringBuilder constructor since 8.0.32

Fixes #901.

Changes

Added logic to check MySqlConnectionStringBuilder constructor.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@moonheart moonheart requested a review from a team January 18, 2023 09:31
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for so fast fix

src/OpenTelemetry.Instrumentation.MySqlData/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
@Kielek Kielek added the comp:instrumentation.mysqldata Things related to OpenTelemetry.Instrumentation.MySqlData label Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #902 (47def4d) into main (6e38cfd) will decrease coverage by 0.08%.
The diff coverage is 63.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   68.55%   68.48%   -0.08%     
==========================================
  Files         183      183              
  Lines        6981     7002      +21     
==========================================
+ Hits         4786     4795       +9     
- Misses       2195     2207      +12     
Impacted Files Coverage Δ
...n.MySqlData/MySqlDataInstrumentationEventSource.cs 71.42% <0.00%> (-28.58%) ⬇️
...trumentation.MySqlData/MySqlDataInstrumentation.cs 77.47% <62.50%> (-6.22%) ⬇️
....Quartz/Implementation/QuartzDiagnosticListener.cs 86.66% <100.00%> (ø)
...Implementation/QuartzInstrumentationEventSource.cs 50.00% <100.00%> (ø)
...rumentation.Quartz/QuartzInstrumentationOptions.cs 100.00% <100.00%> (ø)

@cijothomas cijothomas merged commit 49bcb44 into open-telemetry:main Jan 18, 2023
@cijothomas
Copy link
Member

Merging despite CI failure, due to #903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.mysqldata Things related to OpenTelemetry.Instrumentation.MySqlData
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Instrumentation.MySqlData] It is not working with 8.0.32 release.
4 participants