[Instrumentation.Process, Instrumentation.Process] make configure action nullable #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
added
comp:instrumentation.runtime
alanwest
approved these changes
Jan 20, 2023
Kielek
force-pushed
the
process-runtime-nullable-fix
branch
from
70b5166 to
faeadd6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
+ Coverage 68.42% 68.44% +0.01%
==========================================
Files 183 183
Lines 7006 7004 -2
==========================================
Hits 4794 4794
+ Misses 2212 2210 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #893 #892
Changes
make configure action nullable
based on https://github.com/open-telemetry/opentelemetry-dotnet/pull/3653/files#r970049254 and conversation with @alanwest
For significant contributions please make sure you have completed the following items:
[ ] AppropriateCHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #