Skip to content

Commit

Permalink
cleanup notes
Browse files Browse the repository at this point in the history
  • Loading branch information
reyang committed Sep 6, 2023
1 parent 1284dc0 commit 5a469a8
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions docs/logs/getting-started-aspnetcore/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@
using OpenTelemetry.Logs;
using OpenTelemetry.Resources;

// What should be used for logging before DI is available?
// Remove the comment here, mention in the doc (in the corner) that particular problems can be addressed using explicit logger factory.
// Don't provide the actual guidance, but link to an issue so we can collect feedback from users.

var builder = WebApplication.CreateBuilder(args);

builder.Logging.AddOpenTelemetry(logging =>
Expand Down Expand Up @@ -49,16 +45,6 @@

app.Run();

// Is this even an intended scenario?
//
// app.Logger.LogInformation("Stopping the app..."); // change to a strongly typed, compile time version
// if someone needs to log here, what do they do?
// Noah: use app.Logger here
// Reiley: something destroyed the DI logger so we cannot really do anything here besides changing our recommendation
// use global logger?
// Noah/Reiley: the solution should be the same as what we tell folks to use between entry point and DI readiness
// Tarek: normally folks don't want to log here

public static partial class ApplicationLogs
{
[LoggerMessage(EventId = 1, Level = LogLevel.Information, Message = "Starting the app...")]
Expand Down

0 comments on commit 5a469a8

Please sign in to comment.