Fix issue with resuing tags

open-telemetry · Jan 22, 2022 · b62c0f9 · b62c0f9
1 parent e66874e
commit b62c0f9
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/OpenTelemetry/Metrics/AggregatorStore.cs b/src/OpenTelemetry/Metrics/AggregatorStore.cs
@@ -191,11 +191,13 @@ private int LookupAggregatorStore(string[] tagKeys, object[] tagValues, int leng
             if (!this.sortedTagsDictionary.TryGetValue(givenTags, out var sortedTags))
             {
                 // Note: We are using storage from ThreadStatic, so need to make a deep copy for Dictionary storage.
-                var seqKey = new string[length];
-                tagKeys.CopyTo(seqKey, 0);
+                var givenKeys = new string[length];
+                tagKeys.CopyTo(givenKeys, 0);
 
-                var seqValue = new object[length];
-                tagValues.CopyTo(seqValue, 0);
+                var givenValues = new object[length];
+                tagValues.CopyTo(givenValues, 0);
+
+                givenTags = new Tags(givenKeys, givenValues);
 
                 string[] sortedTagKeys;
                 object[] sortedTagValues;
@@ -214,8 +216,8 @@ private int LookupAggregatorStore(string[] tagKeys, object[] tagValues, int leng
                 }
                 else
                 {
-                    sortedTagKeys = seqKey;
-                    sortedTagValues = seqValue;
+                    sortedTagKeys = givenKeys;
+                    sortedTagValues = givenValues;
                 }
 
                 sortedTags = new Tags(sortedTagKeys, sortedTagValues);