New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grpc.status_code based on spec #1345

Closed

eddynaka opened this issue Oct 13, 2020 · 1 comment · Fixed by #1488

Labels

Contributor

eddynaka commented Oct 13, 2020

Hi,

after the merge of the PR #1313, we will have to keep following the spec open-telemetry/opentelemetry-specification#1044 to decide where we will save the StatusCanonicalCode from grpc.

Right now, I'm re-enabling the original value from GRPC itself.

cc: @alanwest , @cijothomas , @CodeBlanch

eddynaka added the enhancement label

eddynaka mentioned this issue

Updating grpc status code #1488

Merged

3 tasks

Contributor Author

eddynaka commented Nov 6, 2020

Spec updated: open-telemetry/opentelemetry-specification#1156

cijothomas closed this as completed in #1488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment