Updating grpc status code #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1488 +/- ##
==========================================
+ Coverage 81.24% 81.25% +0.01%
==========================================
Files 232 232
Lines 6303 6312 +9
==========================================
+ Hits 5121 5129 +8
- Misses 1182 1183 +1
|
alanwest
reviewed
Nov 8, 2020
test/OpenTelemetry.Instrumentation.Grpc.Tests/GrpcTests.client.cs
Outdated
Show resolved
Hide resolved
alanwest
approved these changes
Nov 8, 2020
cijothomas
reviewed
Nov 10, 2020
src/OpenTelemetry.Instrumentation.GrpcNetClient/GrpcTagHelper.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Nov 10, 2020
| @@ -36,17 +36,16 @@ public static string GetGrpcMethodFromActivity(Activity activity) | |||
| return activity.GetTagValue(GrpcMethodTagName) as string; | |||
| } | |||
|
|
|||
| public static Status GetGrpcStatusCodeFromActivity(Activity activity) | |||
| public static int GetGrpcStatusCodeFromActivity(Activity activity) | |||
There was a problem hiding this comment.
this looks good, you may make it follow the TryGetStatusCode pattern as well.
cijothomas
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1345.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes