Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger Exporter Bugs #1310

Merged
merged 1 commit into from
Sep 26, 2020
Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Sep 26, 2020

Working on open-telemetry/opentelemetry-dotnet-contrib#38 I ran into this issue where none of my http client spans were making it to Jaeger. I tracked this down to a null reference exception being thrown in Jaeger calling ToString() on null tag values (you can still get nulls using Activity.AddTag syntax). While I was fixing that I noticed that we support certain arrays for tag values on Activity but not on ActivityEvent. I fixed that up too.

@CodeBlanch CodeBlanch requested a review from a team September 26, 2020 06:04
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #1310 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
- Coverage   78.56%   78.51%   -0.05%     
==========================================
  Files         219      219              
  Lines        6237     6243       +6     
==========================================
+ Hits         4900     4902       +2     
- Misses       1337     1341       +4     
Impacted Files Coverage Δ
....Jaeger/Implementation/JaegerActivityExtensions.cs 95.73% <100.00%> (+0.16%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 77.77% <0.00%> (-3.18%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 61.76% <0.00%> (-2.95%) ⬇️

@CodeBlanch CodeBlanch merged commit 6633dc8 into open-telemetry:master Sep 26, 2020
@CodeBlanch CodeBlanch deleted the jaeger-nullref branch September 26, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants