Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Propagator from Options #1448

Merged
merged 7 commits into from
Nov 4, 2020
Merged

Removing Propagator from Options #1448

merged 7 commits into from
Nov 4, 2020

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented Nov 3, 2020 •
edited
Loading

Fixes #1439.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka self-assigned this Nov 3, 2020
@eddynaka
Removing Propagator from Options
03c12ea 
updating changelog

fixing tests

fixing tests
@eddynaka
updating changelog
cc694e2
@codecov
Copy link

codecov bot commented Nov 3, 2020 •
edited
Loading

Codecov Report

Merging #1448 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
+ Coverage   81.70%   81.75%   +0.04%     
==========================================
  Files         229      229              
  Lines        6096     6095       -1     
==========================================
+ Hits         4981     4983       +2     
+ Misses       1115     1112       -3
Impacted Files Coverage Δ
...rumentation.AspNet/AspNetInstrumentationOptions.cs 100.00% <ø> (ø)
...ion.AspNetCore/AspNetCoreInstrumentationOptions.cs 100.00% <ø> (ø)
...mentation.Http/HttpClientInstrumentationOptions.cs 100.00% <ø> (ø)
...umentation.AspNet/Implementation/HttpInListener.cs 88.65% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 84.80% <100.00%> (+0.12%) ⬆️
...tp/Implementation/HttpHandlerDiagnosticListener.cs 79.06% <100.00%> (+0.24%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️
src/OpenTelemetry/Sdk.cs 100.00% <0.00%> (+15.38%) ⬆️

@eddynaka eddynaka marked this pull request as ready for review November 3, 2020 21:51
@eddynaka eddynaka requested a review from a team November 3, 2020 21:51
@cijothomas cijothomas closed this Nov 4, 2020
@cijothomas cijothomas reopened this Nov 4, 2020
@cijothomas cijothomas merged commit 7c9bee3 into open-telemetry:master Nov 4, 2020
@eddynaka eddynaka deleted the feature/removing-propagators-options branch November 4, 2020 10:15
cijothomas added a commit that referenced this pull request Nov 4, 2020
@cijothomas
Revert "Removing Propagator from Options (#1448)"
ccd9ae0 
This reverts commit 7c9bee3.
@cijothomas cijothomas mentioned this pull request Nov 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

Assignees

@eddynaka eddynaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instrumentations and overriding Propagator
2 participants
@eddynaka @cijothomas