-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SimpleExporter and BatchExporter for Activity and LogRecord #1622
Added SimpleExporter and BatchExporter for Activity and LogRecord #1622
Conversation
@cijothomas @CodeBlanch I have refactored SimpleExportProcessor and BatchExportProcessor to have type specific implementations. This is in reference to #1574 (comment) I added these four files:
I have updated the SimpleExportProcessor and BatchExportProcessor classes to abstract. The check for Activity.Recorded is in SimpleActivityExportProcessor.cs and BatchActivityExportProcessor.cs. I would love to know your views on this. |
I'd prefer if the base implementations were just called |
@ejsmith We need to have two implementations for Activity. one that implements SimpleExportProcessor and the other that implements BatchExportProcessor. The difference between the two is what you've mentioned but we need to have two different implementations so we need two different class names. I added the prefix Simple and Batch to easily distinguish between them. The same goes for LogRecord. |
Don't want to approve yet because it's a draft but approach LGTM. |
Codecov Report
@@ Coverage Diff @@
## master #1622 +/- ##
==========================================
- Coverage 82.12% 82.09% -0.03%
==========================================
Files 245 249 +4
Lines 6706 6730 +24
==========================================
+ Hits 5507 5525 +18
- Misses 1199 1205 +6
|
…seExportProcessor
…seExportProcessor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@utpilla Please resolve the conflicts. |
Changes