Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Trace.WriteLine instead of Debug.WriteLine for the Debug option #1719

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Use Trace.WriteLine instead of Debug.WriteLine for the Debug option #1719

merged 2 commits into from
Jan 25, 2021

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jan 24, 2021

Fixes #1718

Changes

  • Replaced Debug.WriteLine with Trace.WriteLine in ConsoleExporter.cs

@utpilla utpilla requested a review from a team January 24, 2021 21:04
@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #1719 (e225584) into master (02adc4c) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1719   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files         250      250           
  Lines        6763     6764    +1     
=======================================
+ Hits         5558     5559    +1     
  Misses       1205     1205
Impacted Files Coverage Δ
.../OpenTelemetry.Exporter.Console/ConsoleExporter.cs 37.50% <0.00%> (-5.36%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 94.28% <0.00%> (+1.42%) ⬆️

CodeBlanch
CodeBlanch approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 06666cd into open-telemetry:master Jan 25, 2021
@utpilla utpilla deleted the utpilla/UpdateConsoleExporter branch January 27, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@eddynaka eddynaka eddynaka approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Trace.WriteLine instead of Debug.WriteLine in ConsoleExporter
4 participants
@utpilla @cijothomas @eddynaka @CodeBlanch