Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change branch trigger #1752

Closed

Conversation

cijothomas
Copy link
Member

Trying to see why triggers are not working for all branches.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@cijothomas cijothomas requested a review from a team January 29, 2021 21:30
@reyang
Copy link
Member

reyang commented Jan 29, 2021

Which trigger is not working?

@cijothomas
Copy link
Member Author

Which trigger is not working?
#1751 PR did not trigger the CIs. Its a PR against metrics branch.

(I think we need to update the gh actions in the metrics branch. Because when the PR is against Metrics branch, the workflow file from that branch is used)

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #1752 (987a48e) into main (26953a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1752   +/-   ##
=======================================
  Coverage   82.89%   82.89%           
=======================================
  Files         193      193           
  Lines        6005     6005           
=======================================
  Hits         4978     4978           
  Misses       1027     1027           

@cijothomas
Copy link
Member Author

Which trigger is not working?
#1751 PR did not trigger the CIs. Its a PR against metrics branch.

(I think we need to update the gh actions in the metrics branch. Because when the PR is against Metrics branch, the workflow file from that branch is used)

after main->metric was pushed, this is solved. There is no need of this PR.

@cijothomas cijothomas closed this Jan 29, 2021
@cijothomas cijothomas deleted the cijothomas/ghtrigger2 branch January 29, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants