Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove existing Metrics code #2030

Conversation

cijothomas
Copy link
Member

Given the fact that the whole spec for metrics is re-written, it makes sense to rebuild the implementation.

Removes API, SDK and Prometheus Exporter. Will use git history to get back still useful code especially from Prometheus exporter (when we are ready to write prometheus exporter for new sdk)

@cijothomas cijothomas requested a review from a team May 4, 2021 05:19
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - probably need to update the changelog?

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (metrics@b1df9db). Click here to learn what that means.
The diff coverage is 81.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             metrics    #2030   +/-   ##
==========================================
  Coverage           ?   83.89%           
==========================================
  Files              ?      192           
  Lines              ?     6184           
  Branches           ?        0           
==========================================
  Hits               ?     5188           
  Misses             ?      996           
  Partials           ?        0           
Impacted Files Coverage Δ
...metry.Api/Context/Propagation/BaggagePropagator.cs 83.92% <ø> (ø)
....Exporter.Jaeger/JaegerExporterHelperExtensions.cs 11.11% <0.00%> (ø)
....Exporter.Zipkin/ZipkinExporterHelperExtensions.cs 11.11% <0.00%> (ø)
src/OpenTelemetry/ProviderExtensions.cs 50.00% <0.00%> (ø)
src/OpenTelemetry/Sdk.cs 100.00% <ø> (ø)
src/OpenTelemetry/Trace/SamplingParameters.cs 76.92% <ø> (ø)
...s.Hosting/Trace/TracerProviderBuilderExtensions.cs 17.64% <17.64%> (ø)
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 72.22% <33.33%> (ø)
...ing/Implementation/TracerProviderBuilderHosting.cs 38.46% <38.46%> (ø)
...rc/OpenTelemetry/Trace/TracerProviderExtensions.cs 32.25% <45.45%> (ø)
... and 42 more

@cijothomas cijothomas merged commit 9d415bf into open-telemetry:metrics May 4, 2021
@cijothomas cijothomas deleted the cijothomas/removeexistingmetricscode branch May 4, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants