-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric config modified to look similar to Tracing #2037
Conversation
Codecov Report
@@ Coverage Diff @@
## metrics #2037 +/- ##
========================================
Coverage 82.54% 82.54%
========================================
Files 205 208 +3
Lines 6461 6462 +1
========================================
+ Hits 5333 5334 +1
Misses 1128 1128
|
/// <param name="meterProviderBuilder"><see cref="MeterProviderBuilder"/>.</param> | ||
/// <param name="periodMilliseconds">Perion in milliseconds.</param> | ||
/// <returns><see cref="MeterProvider"/>.</returns> | ||
public static MeterProviderBuilder SetObservationPeriod(this MeterProviderBuilder meterProviderBuilder, int periodMilliseconds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker for this PR.
I guess we will struggle with the ObservationPeriod since there are scenarios where different instruments being observed and reported at different frequency (e.g. during surgery, temperature is observed and reported every minute, blood pressure is observed and reported every 0.5 second, heart beat is observed every 0.1 second but reported every 15 seconds).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree. Will keep this now to continue experimenting with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as an initial step.
I've left some non-blocking comments that we want to revisit later.
Building on top of #2034 . Will be iterating on this :)
Changes:
Make configuration (MeterProviderBuilder) similar to Tracing configuration.
Added console example.
Next steps:
Add Resource to MeterProvider (similar to Tracing model)
Store the metrics into some inmemory exporter(?), and start a unit test framework.