Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial structure for running Processors #2038

Merged
merged 10 commits into from
May 10, 2021

Conversation

victlu
Copy link
Contributor

@victlu victlu commented May 6, 2021

Using existing BaseProcessor, setup our pipeline to be.

API.MeasurementRecorded() -> measurement -> [MeasurementProcessor] -> measurement -> [AggregateProcessor -> [In-Memory]]

CollectTask(In-Memory) -> metrics -> [MetricProcessor] -> metrics -> [ExporterProcessor]

MeasurementProcessor - Allows modification of the measurement values / tags
AggregatorProcessor - Allows aggregation of measurements. Results/states stored in-memory. Just mock in a simple Count/Sum
MetricProcessor - Allows modification of metric (collected from in-memory store)
ExporterProcessor - Allows processing results of aggregators. Just mock to print to Console

@victlu victlu requested a review from a team May 6, 2021 01:45
victlu added 2 commits May 6, 2021 10:48
- Measurment/Metric "Context" changed to "Item"
- refactor processor names
- Use only the OnEnd() method
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #2038 (d64cb4a) into metrics (4faf1d4) will increase coverage by 0.42%.
The diff coverage is 76.43%.

Impacted file tree graph

@@             Coverage Diff             @@
##           metrics    #2038      +/-   ##
===========================================
+ Coverage    82.51%   82.94%   +0.42%     
===========================================
  Files          208      216       +8     
  Lines         6462     6560      +98     
===========================================
+ Hits          5332     5441     +109     
+ Misses        1130     1119      -11     
Impacted Files Coverage Δ
src/System.Diagnostics.Metrics.Temp/Histogram.cs 0.00% <0.00%> (ø)
src/System.Diagnostics.Metrics.Temp/Measurement.cs 50.00% <ø> (+50.00%) ⬆️
...c/System.Diagnostics.Metrics.Temp/MeterListener.cs 85.71% <ø> (+30.54%) ⬆️
...stem.Diagnostics.Metrics.Temp/ObservableCounter.cs 0.00% <0.00%> (ø)
...m.Diagnostics.Metrics.Temp/ObservableInstrument.cs 100.00% <ø> (+33.33%) ⬆️
...iagnostics.Metrics.Temp/ObservableUpDownCounter.cs 0.00% <0.00%> (ø)
src/System.Diagnostics.Metrics.Temp/Meter.cs 17.56% <11.76%> (ø)
src/OpenTelemetry/Metrics/DataPoint{T}.cs 42.85% <42.85%> (ø)
src/System.Diagnostics.Metrics.Temp/Counter.cs 60.00% <57.14%> (ø)
...elemetry/Metrics/MeterProviderBuilderExtensions.cs 66.66% <60.00%> (ø)
... and 27 more

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay to unblock next steps of writing more aggregators.
Quite likely a lot of components gets changed/removed as spec evolves.

@cijothomas cijothomas merged commit 4190b6b into open-telemetry:metrics May 10, 2021
@victlu victlu deleted the processor branch May 10, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants