-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial structure for running Processors #2038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
May 6, 2021
cijothomas
reviewed
May 6, 2021
cijothomas
reviewed
May 6, 2021
- Measurment/Metric "Context" changed to "Item" - refactor processor names - Use only the OnEnd() method
xiang17
reviewed
May 6, 2021
Codecov Report
@@ Coverage Diff @@
## metrics #2038 +/- ##
===========================================
+ Coverage 82.51% 82.94% +0.42%
===========================================
Files 208 216 +8
Lines 6462 6560 +98
===========================================
+ Hits 5332 5441 +109
+ Misses 1130 1119 -11
|
cijothomas
reviewed
May 6, 2021
cijothomas
reviewed
May 6, 2021
bruno-garcia
reviewed
May 7, 2021
cijothomas
approved these changes
May 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay to unblock next steps of writing more aggregators.
Quite likely a lot of components gets changed/removed as spec evolves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using existing BaseProcessor, setup our pipeline to be.
API.MeasurementRecorded() ->
measurement
-> [MeasurementProcessor] ->measurement
-> [AggregateProcessor -> [In-Memory
]]CollectTask(
In-Memory
) ->metrics
-> [MetricProcessor] ->metrics
-> [ExporterProcessor]MeasurementProcessor - Allows modification of the measurement values / tags
AggregatorProcessor - Allows aggregation of measurements. Results/states stored in-memory. Just mock in a simple Count/Sum
MetricProcessor - Allows modification of metric (collected from in-memory store)
ExporterProcessor - Allows processing results of aggregators. Just mock to print to Console