-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial framework for Aggregators #2053
Initial framework for Aggregators #2053
Conversation
Codecov Report
@@ Coverage Diff @@
## metrics #2053 +/- ##
===========================================
- Coverage 82.94% 82.90% -0.04%
===========================================
Files 216 224 +8
Lines 6560 6804 +244
===========================================
+ Hits 5441 5641 +200
- Misses 1119 1163 +44
|
…r LastValueAggregator.
CC @noahfalk for awareness. |
…ggregator level to improve performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Added just a few minor questions/comments that could easily be addressed later if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Left some comments, but we'll keep iterating and improve this as we move forward. I am sure we can do lot more optimizations in the future.
Introduce initial framework for plumbing in Aggregators into Metrics pipeline.
One goal is to avoid any allocations in the "Hot Path".