Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for new [Gauge|Sum|Summary|Histogram]Metric types and aggregators #2073

Merged
merged 9 commits into from
Jun 15, 2021

Conversation

victlu
Copy link
Contributor

@victlu victlu commented Jun 3, 2021

  • Define IGaugeMetric, ISumMetric, ISummaryMetric, and IHistogramMetric
  • Refactor processor pipeline to handle aggregators (aka IMetricBuilder).
  • Refactor AggregatorStore to allow for multiple exporters with different CollectionPeriods.

@victlu victlu requested review from cijothomas and a team June 3, 2021 21:14
@victlu
Copy link
Contributor Author

victlu commented Jun 3, 2021

FYI: @CodeBlanch @alanwest @utpilla

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #2073 (786c636) into metrics (23987a4) will decrease coverage by 1.42%.
The diff coverage is 57.96%.

Impacted file tree graph

@@             Coverage Diff             @@
##           metrics    #2073      +/-   ##
===========================================
- Coverage    83.99%   82.57%   -1.43%     
===========================================
  Files          213      214       +1     
  Lines         6586     6776     +190     
===========================================
+ Hits          5532     5595      +63     
- Misses        1054     1181     +127     
Impacted Files Coverage Δ
...rc/OpenTelemetry/Metrics/DataPoint/DataPoint{T}.cs 0.00% <0.00%> (ø)
src/OpenTelemetry/Metrics/DataPoint/Exemplar.cs 0.00% <0.00%> (ø)
src/OpenTelemetry/Metrics/DataPoint/Exemplar{T}.cs 0.00% <0.00%> (ø)
...trics/MetricAggregators/SummaryMetricAggregator.cs 0.00% <0.00%> (ø)
src/OpenTelemetry/Metrics/DataPoint/DataPoint.cs 37.50% <42.85%> (ø)
...Metrics/MetricAggregators/GaugeMetricAggregator.cs 75.00% <75.00%> (ø)
...y/Metrics/MetricAggregators/SumMetricAggregator.cs 80.00% <80.00%> (ø)
src/OpenTelemetry/Metrics/AggregatorStore.cs 88.57% <90.24%> (+0.43%) ⬆️
...ics/MetricAggregators/HistogramMetricAggregator.cs 97.36% <97.36%> (ø)
src/OpenTelemetry/Metrics/InstrumentState.cs 100.00% <100.00%> (ø)
... and 16 more

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM understanding that things will likely to continue to evolve

@cijothomas cijothomas merged commit 88b732e into open-telemetry:metrics Jun 15, 2021
@victlu victlu deleted the metric-aggregator branch June 15, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants