-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for new [Gauge|Sum|Summary|Histogram]Metric types and aggregators #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
victlu
commented
Jun 3, 2021
- Define IGaugeMetric, ISumMetric, ISummaryMetric, and IHistogramMetric
- Refactor processor pipeline to handle aggregators (aka IMetricBuilder).
- Refactor AggregatorStore to allow for multiple exporters with different CollectionPeriods.
FYI: @CodeBlanch @alanwest @utpilla |
Codecov Report
@@ Coverage Diff @@
## metrics #2073 +/- ##
===========================================
- Coverage 83.99% 82.57% -1.43%
===========================================
Files 213 214 +1
Lines 6586 6776 +190
===========================================
+ Hits 5532 5595 +63
- Misses 1054 1181 +127
|
alanwest
reviewed
Jun 3, 2021
alanwest
reviewed
Jun 3, 2021
alanwest
reviewed
Jun 3, 2021
Add instrument options to example metric console app.
alanwest
reviewed
Jun 11, 2021
src/OpenTelemetry/Metrics/MetricAggregators/GaugeMetricAggregator.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Jun 11, 2021
alanwest
reviewed
Jun 11, 2021
alanwest
reviewed
Jun 11, 2021
alanwest
reviewed
Jun 11, 2021
cijothomas
reviewed
Jun 11, 2021
alanwest
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM understanding that things will likely to continue to evolve
cijothomas
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.