Metric console exporter modified to deal with all known types #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Jun 16, 2021
reyang
reviewed
Jun 16, 2021
| string valueDisplay = string.Empty; | ||
| if (metric is ISumMetric sumMetric) | ||
| { | ||
| if (sumMetric.Sum is double doubleSum) |
There was a problem hiding this comment.
Do we need these if-else conditions or we simply call ToString for whatever point types?
There was a problem hiding this comment.
just to demonstrate that the sum is available as double, if the exporter's backend wants it as double.
(yes in this console, i could just ToString() it.)
Codecov Report
@@ Coverage Diff @@
## metrics #2087 +/- ##
==========================================
Coverage ? 82.45%
==========================================
Files ? 214
Lines ? 6790
Branches ? 0
==========================================
Hits ? 5599
Misses ? 1191
Partials ? 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying ConsoleMetricExporter to explore and demo how an actual Exporter would look like.
(will modify both inmemory and console exporters existing today to support metrics as well, once the exporter interfaces are ready)