Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ActivityTraceId/ActivitySpanId for exemplars #2125

Merged

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Jul 8, 2021

@victlu I think it might make sense to use the .NET ActivityTraceId and ActivitySpanId types on exemplars. Or was your choice of byte[] intentional?

@alanwest alanwest requested a review from a team July 8, 2021 22:32
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #2125 (a4ba180) into metrics (95a1367) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           metrics    #2125      +/-   ##
===========================================
+ Coverage    82.96%   83.02%   +0.05%     
===========================================
  Files          211      211              
  Lines         6694     6692       -2     
===========================================
+ Hits          5554     5556       +2     
+ Misses        1140     1136       -4     
Impacted Files Coverage Δ
src/OpenTelemetry/Metrics/DataPoint/Exemplar.cs 0.00% <0.00%> (ø)
src/OpenTelemetry/Metrics/DataPoint/Exemplar{T}.cs 0.00% <0.00%> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+2.94%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@victlu
Copy link
Contributor

victlu commented Jul 9, 2021

@victlu I think it might make sense to use the .NET ActivityTraceId and ActivitySpanId types on exemplars. Or was your choice of byte[] intentional?

I was lazy and just matching bytes type for span_id/trace_id in the OTLP protocol. Having more concrete types is better!

@cijothomas cijothomas merged commit 8a89dbd into open-telemetry:metrics Jul 9, 2021
@alanwest alanwest deleted the alanwest/exemplar-refactor branch July 9, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants