Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify MeterProvider to no longer maintain instrument state #2134

Merged

Conversation

cijothomas
Copy link
Member

Changes

Modify MeterProvider to no longer maintain instrument state as the state is expected to come from the API callbacks.
Just a small cleanup, as part of more refactorings in the subsequent PRs.

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@cijothomas cijothomas requested a review from a team July 14, 2021 14:12
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (metrics@be1d13f). Click here to learn what that means.
The diff coverage is 77.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             metrics    #2134   +/-   ##
==========================================
  Coverage           ?   83.59%           
==========================================
  Files              ?      211           
  Lines              ?     6692           
  Branches           ?        0           
==========================================
  Hits               ?     5594           
  Misses             ?     1098           
  Partials           ?        0           
Impacted Files Coverage Δ
....Exporter.Jaeger/JaegerExporterHelperExtensions.cs 11.11% <0.00%> (ø)
...Telemetry.Exporter.Jaeger/JaegerExporterOptions.cs 100.00% <ø> (ø)
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 87.64% <ø> (ø)
....Exporter.Zipkin/ZipkinExporterHelperExtensions.cs 11.11% <0.00%> (ø)
...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs 100.00% <ø> (ø)
...ion.AspNetCore/AspNetCoreInstrumentationOptions.cs 100.00% <ø> (ø)
src/OpenTelemetry/BaseExportProcessor.cs 84.21% <ø> (ø)
src/OpenTelemetry/BatchLogRecordExportProcessor.cs 0.00% <0.00%> (ø)
src/OpenTelemetry/Metrics/DataPoint/DataPoint.cs 0.00% <0.00%> (ø)
...rc/OpenTelemetry/Metrics/DataPoint/DataPoint{T}.cs 0.00% <0.00%> (ø)
... and 77 more

@cijothomas cijothomas merged commit 8f525df into open-telemetry:metrics Jul 14, 2021
@cijothomas cijothomas deleted the cijothomas/metricsstatefromapi branch July 14, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants