-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a very basic prometheus exporter #2143
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
007a2ae
Add very basic prometheus support
cijothomas 8c84be5
Merge branch 'metrics' into cijothomas/addprometheusbasic
cijothomas 7bd5e45
Add prometheus example
cijothomas 946fa7f
remove unwanted file
cijothomas 3a8267d
pr comment
cijothomas fbcb7d8
supress promtheus
cijothomas c31273b
try catch
cijothomas 7eef7e7
remove space
cijothomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
src/OpenTelemetry.Exporter.Prometheus/Implementation/PrometheusExporterEventSource.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
// <copyright file="PrometheusExporterEventSource.cs" company="OpenTelemetry Authors"> | ||
// Copyright The OpenTelemetry Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// </copyright> | ||
|
||
using System; | ||
using System.Diagnostics.Tracing; | ||
using OpenTelemetry.Internal; | ||
|
||
namespace OpenTelemetry.Exporter.Prometheus.Implementation | ||
{ | ||
/// <summary> | ||
/// EventSource events emitted from the project. | ||
/// </summary> | ||
[EventSource(Name = "OpenTelemetry-Exporter-Prometheus")] | ||
internal class PrometheusExporterEventSource : EventSource | ||
{ | ||
public static PrometheusExporterEventSource Log = new PrometheusExporterEventSource(); | ||
|
||
[NonEvent] | ||
public void FailedExport(Exception ex) | ||
{ | ||
if (this.IsEnabled(EventLevel.Error, (EventKeywords)(-1))) | ||
{ | ||
this.FailedExport(ex.ToInvariantString()); | ||
} | ||
} | ||
|
||
[NonEvent] | ||
public void FailedShutdown(Exception ex) | ||
{ | ||
if (this.IsEnabled(EventLevel.Error, (EventKeywords)(-1))) | ||
{ | ||
this.FailedShutdown(ex.ToInvariantString()); | ||
} | ||
} | ||
|
||
[NonEvent] | ||
public void CanceledExport(Exception ex) | ||
{ | ||
if (this.IsEnabled(EventLevel.Error, (EventKeywords)(-1))) | ||
{ | ||
this.CanceledExport(ex.ToInvariantString()); | ||
} | ||
} | ||
|
||
[Event(1, Message = "Failed to export metrics: '{0}'", Level = EventLevel.Error)] | ||
public void FailedExport(string exception) | ||
{ | ||
this.WriteEvent(1, exception); | ||
} | ||
|
||
[Event(2, Message = "Canceled to export metrics: '{0}'", Level = EventLevel.Error)] | ||
public void CanceledExport(string exception) | ||
{ | ||
this.WriteEvent(2, exception); | ||
} | ||
|
||
[Event(3, Message = "Failed to shutdown Metrics server '{0}'", Level = EventLevel.Error)] | ||
public void FailedShutdown(string exception) | ||
{ | ||
this.WriteEvent(3, exception); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the simplicity here. User is not expected to anything about temporality (delta vs cumulative)!. Hope it can stay that way..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, because Prometheus is always cumulative right? I guess the only thing that would change this is if Prometheus introduced support for delta aggregations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea.. Views will likely make this more complex :)