Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove net452 and net46 from the in-memory exporter project #2144

Conversation

joaopgrassi
Copy link
Member

Another project from #2138

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@joaopgrassi joaopgrassi requested a review from a team July 16, 2021 20:01
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #2144 (e6a98be) into main (17ed3f3) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
- Coverage   85.00%   84.99%   -0.02%     
==========================================
  Files         187      187              
  Lines        6124     6124              
==========================================
- Hits         5206     5205       -1     
- Misses        918      919       +1     
Impacted Files Coverage Δ
...rter.InMemory/InMemoryExporterLoggingExtensions.cs 0.00% <ø> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joaopgrassi
Copy link
Member Author

I missed the OpenTelemetry.Tests using the InMemory project.. as these don't run on Linux :(. I guess we can leave this and merge once that one is also changed to remove these targets?

@cijothomas
Copy link
Member

I missed the OpenTelemetry.Tests using the InMemory project.. as these don't run on Linux :(. I guess we can leave this and merge once that one is also changed to remove these targets?

You can remove net452 and net46 from OpenTelemetry.Tests and instead add net461

Now that InMemory is also not supporting those..
@joaopgrassi
Copy link
Member Author

joaopgrassi commented Jul 16, 2021

You can remove net452 and net46 from OpenTelemetry.Tests and instead add net461

Yep, done!

@@ -14,7 +14,7 @@
// limitations under the License.
// </copyright>

#if !NET452 && !NET46
#if !NET461
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll get rid of netcore2.1 soon, so this'd be lot more simpler.! (2.1 is EOL next month!) We can start removing as soon as the current wave of .netframework removals.

@cijothomas cijothomas merged commit 64b967a into open-telemetry:main Jul 17, 2021
@joaopgrassi joaopgrassi deleted the joaopgrassi/remove_net452_inmemexporter branch July 17, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants