-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove net452 and net46 from the in-memory exporter project #2144
Remove net452 and net46 from the in-memory exporter project #2144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #2144 +/- ##
==========================================
- Coverage 85.00% 84.99% -0.02%
==========================================
Files 187 187
Lines 6124 6124
==========================================
- Hits 5206 5205 -1
- Misses 918 919 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I missed the |
Co-authored-by: Reiley Yang <reyang@microsoft.com>
You can remove net452 and net46 from OpenTelemetry.Tests and instead add net461 |
Now that InMemory is also not supporting those..
Yep, done! |
@@ -14,7 +14,7 @@ | |||
// limitations under the License. | |||
// </copyright> | |||
|
|||
#if !NET452 && !NET46 | |||
#if !NET461 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll get rid of netcore2.1 soon, so this'd be lot more simpler.! (2.1 is EOL next month!) We can start removing as soon as the current wave of .netframework removals.
Another project from #2138
CHANGELOG.md
updated for non-trivial changes