-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove net452 from shims project #2146
Remove net452 from shims project #2146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Reiley Yang <reyang@microsoft.com>
src/OpenTelemetry.Shims.OpenTracing/OpenTelemetry.Shims.OpenTracing.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add net461 as there is no other netframework target here.
Codecov Report
@@ Coverage Diff @@
## main #2146 +/- ##
==========================================
- Coverage 85.00% 84.99% -0.02%
==========================================
Files 187 187
Lines 6124 6124
==========================================
- Hits 5206 5205 -1
- Misses 918 919 +1
|
I think I fixed the remaining issues @cijothomas. Just something I noticed: Is there a reason why the package In order to generate the public api files, I had to manually add the package and run |
I don't recollect why... If you can make PR to do it in both win/linux, and if that makes its easy for linux based devs to catch issues easily, we can take it. Thanks! |
Another project from #2138
CHANGELOG.md
updated for non-trivial changes