Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove net452 from shims project #2146

Merged

Conversation

joaopgrassi
Copy link
Member

Another project from #2138

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@joaopgrassi joaopgrassi requested a review from a team July 16, 2021 20:34
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joaopgrassi joaopgrassi changed the title Remove net452 from shims project (#2139) Remove net452 from shims project Jul 16, 2021
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add net461 as there is no other netframework target here.

@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #2146 (4e6edfe) into main (a3867d4) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
- Coverage   85.00%   84.99%   -0.02%     
==========================================
  Files         187      187              
  Lines        6124     6124              
==========================================
- Hits         5206     5205       -1     
- Misses        918      919       +1     
Impacted Files Coverage Δ
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 95.34% <0.00%> (-0.78%) ⬇️

@joaopgrassi
Copy link
Member Author

joaopgrassi commented Jul 17, 2021

I think I fixed the remaining issues @cijothomas.

Just something I noticed: Is there a reason why the package Microsoft.CodeAnalysis.PublicApiAnalyzers is only added on Windows? I ran a build/test locally and didn't get any errors because I use Linux, but then I saw the CI failing..

In order to generate the public api files, I had to manually add the package and run dotnet format -a warn. Since all worked fine, I wonder if we can't just always add the package? Then people would not forget to add the api files like I did. It's the first time I use this, so just asking to understand it.

@cijothomas cijothomas merged commit 17ed3f3 into open-telemetry:main Jul 17, 2021
@cijothomas
Copy link
Member

I think I fixed the remaining issues @cijothomas.

Just something I noticed: Is there a reason why the package Microsoft.CodeAnalysis.PublicApiAnalyzers is only added on Windows? I ran a build/test locally and didn't get any errors because I use Linux, but then I saw the CI failing..

In order to generate the public api files, I had to manually add the package and run dotnet format -a warn. Since all worked fine, I wonder if we can't just always add the package? Then people would not forget to add the api files like I did. It's the first time I use this, so just asking to understand it.

I don't recollect why... If you can make PR to do it in both win/linux, and if that makes its easy for linux based devs to catch issues easily, we can take it. Thanks!

@joaopgrassi joaopgrassi deleted the joaopgrassi/remove_net452_shims branch July 18, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants