Add Resource support for MetricProvider #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Jul 17, 2021
| @@ -75,6 +93,8 @@ public override ExportResult Export(in Batch<MetricItem> batch) | |||
|
|
|||
| string time = $"{metric.StartTimeExclusive.ToLocalTime().ToString("HH:mm:ss.fff")} {metric.EndTimeInclusive.ToLocalTime().ToString("HH:mm:ss.fff")}"; | |||
|
|
|||
|
|
|||
reyang
reviewed
Jul 17, 2021
| @@ -20,8 +20,22 @@ namespace OpenTelemetry.Metrics | |||
| { | |||
| public abstract class MetricProcessor : BaseProcessor<MetricItem> | |||
| { | |||
| protected readonly BaseExporter<MetricItem> exporter; | |||
Codecov Report
@@ Coverage Diff @@
## metrics #2150 +/- ##
===========================================
- Coverage 75.36% 75.18% -0.19%
===========================================
Files 215 216 +1
Lines 6893 6910 +17
===========================================
Hits 5195 5195
- Misses 1698 1715 +17
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Resource support to MeterProvider, making it more closely aligned with TracerProvider.