Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove net452 and net46 from asp.net #2153

Merged
merged 4 commits into from
Jul 19, 2021
Merged

Conversation

cijothomas
Copy link
Member

Part of #2138

Also removed from Otel.Shared project, which is never released as stable.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@cijothomas cijothomas requested a review from a team July 19, 2021 17:01
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #2153 (0fbdb8f) into main (c17d794) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2153      +/-   ##
==========================================
+ Coverage   85.00%   85.20%   +0.19%     
==========================================
  Files         187      186       -1     
  Lines        6124     6109      -15     
==========================================
- Hits         5206     5205       -1     
+ Misses        918      904      -14     
Impacted Files Coverage Δ
...nTelemetry/Internal/SelfDiagnosticsConfigParser.cs 82.60% <0.00%> (-0.38%) ⬇️
...emetry/Internal/DateTimeOffsetExtensions.net452.cs
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.63% <0.00%> (+1.51%) ⬆️
...penTelemetry/Internal/ServiceProviderExtensions.cs 100.00% <0.00%> (+33.33%) ⬆️

@cijothomas cijothomas merged commit 9d9c3d5 into main Jul 19, 2021
@cijothomas cijothomas deleted the cijothomas/removenet452aspnet branch July 19, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants