Remove NET452 NET46 from OpenTelemetry sdk #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
approved these changes
Jul 20, 2021
Codecov Report
@@ Coverage Diff @@
## main #2163 +/- ##
==========================================
- Coverage 85.20% 85.15% -0.05%
==========================================
Files 186 186
Lines 6103 6096 -7
==========================================
- Hits 5200 5191 -9
- Misses 903 905 +2
|
|
Waiting for one more approval, as this is bit larger PR, and it touches the heart of this repo! |
reyang
reviewed
Jul 20, 2021
reyang
reviewed
Jul 20, 2021
| @@ -55,11 +55,7 @@ public SelfDiagnosticsEventListener(EventLevel logLevel, SelfDiagnosticsConfigRe | |||
|
|
|||
| foreach (var eventSource in eventSources) | |||
| { | |||
| #if NET452 | |||
| this.EnableEvents(eventSource, this.logLevel, (EventKeywords)(-1)); | |||
There was a problem hiding this comment.
Finally 👍
IIRC there are many places where we have (EventKeywords)(-1) (check out this link), probably not fully covered by this PR. Can be a separate PR though - up to you 😺
reyang
reviewed
Jul 20, 2021
| @@ -1,6 +1,6 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>netstandard2.0;net452;net46;net461</TargetFrameworks> | |||
| <TargetFrameworks>netstandard2.0;net461</TargetFrameworks> | |||
There was a problem hiding this comment.
After this PR we might be able to consolidate these TargetFrameworks (e.g. using the default setting in the top level .props file).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2138
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes