-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NET452 NET46 from OpenTelemetry sdk #2163
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2163 +/- ##
==========================================
- Coverage 85.20% 85.15% -0.05%
==========================================
Files 186 186
Lines 6103 6096 -7
==========================================
- Hits 5200 5191 -9
- Misses 903 905 +2
|
Waiting for one more approval, as this is bit larger PR, and it touches the heart of this repo! |
@@ -55,11 +55,7 @@ public SelfDiagnosticsEventListener(EventLevel logLevel, SelfDiagnosticsConfigRe | |||
|
|||
foreach (var eventSource in eventSources) | |||
{ | |||
#if NET452 | |||
this.EnableEvents(eventSource, this.logLevel, (EventKeywords)(-1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally 👍
IIRC there are many places where we have (EventKeywords)(-1)
(check out this link), probably not fully covered by this PR. Can be a separate PR though - up to you 😺
@@ -1,6 +1,6 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> | |||
<PropertyGroup> | |||
<TargetFrameworks>netstandard2.0;net452;net46;net461</TargetFrameworks> | |||
<TargetFrameworks>netstandard2.0;net461</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this PR we might be able to consolidate these TargetFrameworks
(e.g. using the default setting in the top level .props
file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Part of #2138
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes