Small cleanup on MeterProvider #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## metrics #2172 +/- ##
===========================================
+ Coverage 74.58% 74.60% +0.01%
===========================================
Files 218 218
Lines 6957 6957
===========================================
+ Hits 5189 5190 +1
+ Misses 1768 1767 -1
|
reyang
approved these changes
Jul 21, 2021
reyang
reviewed
Jul 21, 2021
| @@ -61,6 +61,7 @@ protected override void Dispose(bool disposing) | |||
| { | |||
| this.token.Cancel(); | |||
| this.exporter.Dispose(); | |||
| this.exportTask.Wait(); | |||
There was a problem hiding this comment.
Btw, do we see the real difference between push/pull metric processors? I personally don't (and I'm thinking maybe we should remove push/pull concept from the draft spec).
There was a problem hiding this comment.
Not much, since the MeterProvider provided a way to "Collect". PushProcessor calls this Collect every N seconds. PullProcessor calls this Collect whenever its asked to.
reyang
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider doesn't have any tasks, so its dispose simply calls dispose on the processors (which may have tasks to be disposed)