Fix build #2226
Merged
Fix build #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
10 tasks
reyang
commented
Aug 4, 2021
| <!--PackageVersion></PackageVersion--> | ||
| <Authors>Microsoft</Authors> | ||
| <Title>Microsoft Asp.Net telemetry correlation</Title> | ||
| <TargetFrameworks>net461</TargetFrameworks> |
There was a problem hiding this comment.
@cijothomas @rajkumar-rangaraj do you see a problem here if we target net461? Previously the target was <TargetFrameworks>net45</TargetFrameworks>.
There was a problem hiding this comment.
this should be okay.
if anyone wants to use older than net461, then they can use the aspnet package.
Since Otel itself stopped support for older than net461, otel users shouldn't have issue either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2222.
Changes
.csprojfile and fixed all build warnings/errors undersrc.