Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design for TelemetryHttpModule using ActivitySource + OpenTelemetry.API part 2 #2254

Conversation

CodeBlanch
Copy link
Member

Relates to #2249

Changes

  • TelemetryHttpModule previously used 2 HttpContext.Items keys for its state management. Now it uses a single one. This really just simplifies things and makes the perf a little better avoiding an extra trip or two to the hash table.

@CodeBlanch CodeBlanch requested a review from a team August 12, 2021 19:10
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CodeBlanch CodeBlanch merged commit a012493 into open-telemetry:aspnet-telemetrycorrelation-otelintegration Aug 13, 2021
@CodeBlanch CodeBlanch deleted the aspnet-telemetrycorrelation-otelintegration-part2 branch August 13, 2021 16:12
CodeBlanch added a commit that referenced this pull request Aug 25, 2021
…e + OpenTelemetry.API (#2270)

* New design for TelemetryHttpModule using ActivitySource + OpenTelemetry.API. (#2249)

* New design for TelemetryHttpModule using ActivitySource + OpenTelemetry.API part 2 (#2254)

* Use a single context.Items key for state management to make things more efficient.

* Added a comment for clarity.

* Code review.

* New design for TelemetryHttpModule using ActivitySource + OpenTelemetry.API part 3 (#2256)

* Update ASP.NET instrumentation to use the new TelemetryHttpModule.

* Fixed TelemetryHttpModule not starting its Activity objects. Added an example of request suppression.

* Tweaks an logging improvements.

* Sealed AspNetInstrumentationEventSource.

* Code review.

* New design for TelemetryHttpModule using ActivitySource + OpenTelemetry.API part 4 (#2258)

* Fixed up TelemetryHttpModule unit tests.

* Added tests for the new HasStarted helper and added checks for StartedButNotSampledObj when not sampled.

* Code review.

* New design for TelemetryHttpModule using ActivitySource + OpenTelemetry.API part 5 (#2261)

* Updated ASP.NET instrumentation tests for new TelemetryHttpModule.

* Added a test for the new RecordException option.

* Code review.

* New design for TelemetryHttpModule using ActivitySource + OpenTelemetry.API part 6 (#2264)

* CHANGELOG & README updates.

* Apply suggestions from code review

Co-authored-by: Reiley Yang <reyang@microsoft.com>

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Lint + sanity checks.

* Lint attempt 2.

* Restored CHANGELOG changes lost in merge.

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants