Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET Framework HttpClient Instrumentation: Fix missing events on instances created before TracerProvider (Part 2) #2375

Merged
merged 7 commits into from
Sep 20, 2021
Merged

.NET Framework HttpClient Instrumentation: Fix missing events on instances created before TracerProvider (Part 2) #2375

merged 7 commits into from
Sep 20, 2021

Conversation

CodeBlanch
Copy link
Member

Follow-up to #2364

Changes

  • Updated CHANGELOG
  • Added a unit test
  • Fixed an issue the unit test exposed

@CodeBlanch CodeBlanch requested a review from a team September 17, 2021 18:19
@codecov
Copy link

codecov bot commented Sep 17, 2021 •
edited
Loading

Codecov Report

Merging #2375 (947bf78) into main (67e4e07) will not change coverage.
The diff coverage is n/a.

❗ Current head 947bf78 differs from pull request most recent head 1682fd4. Consider uploading reports for the commit 1682fd4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2375   +/-   ##
=======================================
  Coverage   79.76%   79.76%           
=======================================
  Files         231      231           
  Lines        7459     7459           
=======================================
  Hits         5950     5950           
  Misses       1509     1509

pellared
pellared approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md Outdated Show resolved Hide resolved
@CodeBlanch CodeBlanch merged commit 58054d1 into open-telemetry:main Sep 20, 2021
@CodeBlanch CodeBlanch deleted the httpclient-attach-existing-part2 branch September 20, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

@pellared pellared pellared approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodeBlanch @pellared @cijothomas