Changes around MeterProviderSdk, resolving pending comments. #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2474 +/- ##
=======================================
Coverage 79.79% 79.79%
=======================================
Files 254 254
Lines 8394 8395 +1
=======================================
+ Hits 6698 6699 +1
Misses 1696 1696
|
cijothomas
reviewed
Oct 11, 2021
| @@ -231,8 +231,17 @@ public void MeterSourcesWildcardSupportMatchTest(bool hasView) | |||
| [Theory] | |||
| [InlineData(true)] | |||
| [InlineData(false)] | |||
| public void MeterSourcesWildcardSupportWithoutAddingMeterToProvider(bool hasView) | |||
| public void MeterSourcesWildcardSupportNegativeTestNoMeterAdded(bool hasView) | |||
There was a problem hiding this comment.
If there are no Meters added, then I think the SDK should throw. (This is not yet done, so this test is currently validating the current behavior)
There was a problem hiding this comment.
cijothomas
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved pending comments:
#2459 (comment)
#2459 (comment)