[DO NOT MERGE] Exporter should not be allowed to update MetricPoint in the AggregatorStore #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n MetricPoint array of the Aggregator store
utpilla
commented
Dec 7, 2021
| { | ||
| foreach (ref var metricPoint in metric.GetMetricPoints()) | ||
| { | ||
| metricPoint = default; |
There was a problem hiding this comment.
This is allowed as of today.
There was a problem hiding this comment.
Good call @utpilla! If you change this line...
...to...
public readonly ref MetricPoint Current...does that fix it?
There was a problem hiding this comment.
Yeah ref readonly should fix it. We would have to update the exporters though which should be fine.
utpilla
commented
Dec 7, 2021
| { | ||
| foreach (var metric in batch) | ||
| { | ||
| if (invocationCount > 1) |
There was a problem hiding this comment.
I'm not updating the MetricPoint the first time so that we can test that things were working correctly up until we updated the MetricPoint.
utpilla
commented
Dec 7, 2021
|
|
||
| meterProvider.ForceFlush(); | ||
|
|
||
| Assert.Single(exportedItems); |
There was a problem hiding this comment.
At this point, ForceFlush() has called the Export method of the exporter and the exporter has updated the original MetricPoint to default.
3 tasks
|
I have created #2736 to fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enumerator of Metric.GetMetricPoints() returns a reference to the
MetricPointin theMetricPoint[]used in theAggregatorStore. Since we return a reference to theMetricPoint, an exporter can set its value todefaultand thus change the original entry in theMetricPoint[]. This can clearly interfere with SDK's working.Changes
MetricPointof theMetricPoint[]ofAggregatorStore