Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail-fast when using AddView with guaranteed conflict #2785

Merged
merged 4 commits into from
Jan 14, 2022

Conversation

cijothomas
Copy link
Member

Fixes #2751

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@cijothomas cijothomas requested a review from a team January 13, 2022 21:08
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #2785 (1cbeb27) into main (26ac74d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2785      +/-   ##
==========================================
+ Coverage   83.78%   83.82%   +0.03%     
==========================================
  Files         251      251              
  Lines        8845     8857      +12     
==========================================
+ Hits         7411     7424      +13     
+ Misses       1434     1433       -1     
Impacted Files Coverage Δ
...elemetry/Metrics/MeterProviderBuilderExtensions.cs 76.47% <100.00%> (+7.23%) ⬆️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️

@cijothomas cijothomas merged commit 8138e5e into open-telemetry:main Jan 14, 2022
@cijothomas cijothomas deleted the cijothomas/viewff branch January 14, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddView validations based on new spec
3 participants