-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IResourceDetector public to allow custom implementations of resource detectors. #2897
Make IResourceDetector public to allow custom implementations of resource detectors. #2897
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2897 +/- ##
==========================================
+ Coverage 84.21% 84.22% +0.01%
==========================================
Files 251 251
Lines 8883 8883
==========================================
+ Hits 7481 7482 +1
+ Misses 1402 1401 -1
|
I updated the description so that merging would not auto close the linked issue. This PR doesn't resolve the issue but rather enables implementing the issue. |
A good immediate follow up would be to document this for https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/trace/extending-the-sdk . (The doc is tied to tracing, we need to separate it out to more common place, but that can be a separate issue.) @Yun-Ting Could you create an issue for these and/or propose a doc update with this? |
Shipping actual detectors could be something for the -contrib repo? We can move the issue to -contrib repo. |
Thanks Alan 🤗! I'll be more careful the next time. |
Related to #2752.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes