fix: http 400 status is not error on server

[nordfjord]

The specification here https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#status.

Says:

For HTTP status codes in the 4xx range span status MUST be left unset in case of SpanKind.SERVER and MUST be set to Error in case of SpanKind.CLIENT

Changes

For significant contributions please make sure you have completed the following items:

[reyang]

Thanks @nordfjord! Would you help to update the changelog?

[reyang]

LGTM assuming changelog is updated.
It might be nice to include some test cases.

[codecov]

Codecov Report

Merging #2904 (d234277) into main (a2c1b6e) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2904      +/-   ##
==========================================
+ Coverage   84.20%   84.36%   +0.15%     
==========================================
  Files         252      252              
  Lines        8895     8896       +1     
==========================================
+ Hits         7490     7505      +15     
+ Misses       1405     1391      -14     

Impacted Files	Coverage Δ
src/OpenTelemetry.Api/Internal/SpanHelper.cs	100.00% <100.00%> (ø)
...umentation.AspNet/Implementation/HttpInListener.cs	88.60% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs	86.42% <100.00%> (ø)
...tp/Implementation/HttpHandlerDiagnosticListener.cs	71.57% <100.00%> (ø)
...Telemetry/Internal/SelfDiagnosticsEventListener.cs	96.87% <0.00%> (-0.79%)	⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs	75.00% <0.00%> (+2.77%)	⬆️
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs	89.42% <0.00%> (+2.88%)	⬆️
...mentation/ExportClient/BaseOtlpGrpcExportClient.cs	62.50% <0.00%> (+12.50%)	⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs	50.00% <0.00%> (+14.28%)	⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs	59.09% <0.00%> (+22.72%)	⬆️

[nordfjord]

Thanks, I've added the changelog entry 🎉 .

Happy to change the entry if necessary as well.

[alanwest]

Nice, thanks for catching this!

[cijothomas]

LGTM - need to fix the link in changelog and add one for aspnet, and we are good to merge.

[cijothomas]

Merging. Only modifying Instrumentation libraries, and not Core components.