Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock-free updates for Histogram #2951

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/OpenTelemetry/Metrics/HistogramBuckets.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ public class HistogramBuckets

internal double SnapshotSum;

internal int UsingHistogram = 0;
utpilla marked this conversation as resolved.
Show resolved Hide resolved

internal HistogramBuckets(double[] explicitBounds)
{
this.ExplicitBounds = explicitBounds;
Expand Down
20 changes: 16 additions & 4 deletions src/OpenTelemetry/Metrics/MetricPoint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -323,11 +323,23 @@ internal void Update(double number)
}
}

lock (this.histogramBuckets.LockObject)
var sw = default(SpinWait);
while (true)
{
this.runningValue.AsLong++;
this.histogramBuckets.RunningSum += number;
this.histogramBuckets.RunningBucketCounts[i]++;
if (Interlocked.Exchange(ref this.histogramBuckets.UsingHistogram, 1) == 0)
{
unchecked
{
this.runningValue.AsLong++;
this.histogramBuckets.RunningSum += number;
this.histogramBuckets.RunningBucketCounts[i]++;
}

this.histogramBuckets.UsingHistogram = 0;
break;
}

sw.SpinOnce();
cijothomas marked this conversation as resolved.
Show resolved Hide resolved
}

break;
Expand Down