Add AspNet metrics instrumentation #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2985 +/- ##
==========================================
+ Coverage 84.09% 84.23% +0.13%
==========================================
Files 255 258 +3
Lines 9062 9090 +28
==========================================
+ Hits 7621 7657 +36
+ Misses 1441 1433 -8
|
cijothomas
reviewed
Mar 8, 2022
| new KeyValuePair<string, object>(SemanticConventions.AttributeHttpStatusCode, context.Response.StatusCode), | ||
| }; | ||
|
|
||
| this.httpServerDuration.Record(activity.Duration.TotalMilliseconds, tags); |
There was a problem hiding this comment.
We need to fix the issue of this depending on tracing being enabled for metrics to work. But this limitation already exists in aspnet core as well. It is okay to merge this for an initial release. This is better than nothing.
(We definitely need to remove the Metrics dependency on Tracing before stable.)
utpilla
reviewed
Mar 8, 2022
src/OpenTelemetry.Instrumentation.AspNet/Implementation/HttpInMetricsListener.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Mar 9, 2022
src/OpenTelemetry.Instrumentation.AspNet/Implementation/HttpInMetricsListener.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Mar 9, 2022
test/OpenTelemetry.Instrumentation.AspNet.Tests/HttpInMetricsListenerTests.cs
Outdated
Show resolved
Hide resolved
utpilla
approved these changes
Mar 9, 2022
utpilla
reviewed
Mar 9, 2022
mic-max
reviewed
Mar 9, 2022
utpilla
approved these changes
Mar 9, 2022
utpilla
reviewed
Mar 9, 2022
test/OpenTelemetry.Instrumentation.AspNet.Tests/HttpInMetricsListenerTests.cs
Show resolved
Hide resolved
Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>
cijothomas
reviewed
Mar 9, 2022
| /// <inheritdoc/> | ||
| public void Dispose() | ||
| { | ||
| this.meter?.Dispose(); |
cijothomas
approved these changes
Mar 9, 2022
|
@vishweshbankwar Could you update the example asp.net app to leverage this? https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/examples/AspNet/Global.asax.cs |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2556
Changes
This change enables
http.server.durationmetric collection noted in spec for ASP.NET applications. It relies on activity to calculate the duration however, we need to update this at a later stage to make it independent of trace/activity creation. Opened #2994For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes