-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isRemote check for context propagation #3329
Merged
cijothomas
merged 13 commits into
open-telemetry:main
from
vishweshbankwar:vibankwa/3315
Jun 6, 2022
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f9d423b
Add isRemote chekc for context propagation
vishweshbankwar de0573f
update changelog
vishweshbankwar ea48192
Merge branch 'main' into vibankwa/3315
vishweshbankwar 523decb
Merge branch 'main' into vibankwa/3315
vishweshbankwar 95c59d1
resolve pr comments
vishweshbankwar 196ad18
Merge branch 'vibankwa/3315' of https://github.com/vishweshbankwar/op…
vishweshbankwar 43f8de6
reword chagelog
vishweshbankwar c7b7161
Merge branch 'main' into vibankwa/3315
vishweshbankwar 3194863
Merge branch 'main' into vibankwa/3315
vishweshbankwar 594bf0d
Merge branch 'vibankwa/3315' of https://github.com/vishweshbankwar/op…
vishweshbankwar 3615b7b
Merge branch 'main' into vibankwa/3315
vishweshbankwar c9880cc
refactor for minor perf
vishweshbankwar fb2d5a6
minor
vishweshbankwar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably explore updating the method signature here to something like this:
private static ActivitySamplingResult PropagateOrIgnoreData(in ActivityContext parentContext)
and pass inoptions.Parent
to this method.ActivityContext
is areadonly struct
so using thein
modifier might give some minor perf gains.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor:
I have updated the method signature